Merge lp:~dobey/ubuntuone-credentials/auto-tab into lp:ubuntuone-credentials

[dobey]

Don't do manual tab key handling in the UI.

[unity-api-1-bot (unity-api-1-bot)]

PASSED: Continuous integration, rev:255
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntuone-credentials-ci/32/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/991
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/998
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/795
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/795/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/795
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/795/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/795
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/795/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/795
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/795/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/795
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/795/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/795
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/795/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/795
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/795/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/795
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/795/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/795
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/795/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntuone-credentials-ci/32/rebuild

review: Approve (continuous-integration)

[Ted Gould (ted)]

Works for me.

review: Approve

=== modified file 'online-accounts-provider/LoginForm.qml'
--- online-accounts-provider/LoginForm.qml	2016-03-21 14:48:41 +0000
+++ online-accounts-provider/LoginForm.qml	2016-11-03 17:00:00 +0000
@@ -40,8 +40,6 @@
         width: main.width - (2 * main.anchors.margins)
 
         Keys.onReturnPressed: main.processForm();
-        KeyNavigation.tab: twoFactorUI.visible ? twoFactorTextField : emailTextField /* from main */
-        KeyNavigation.backtab: emailTextField /* from main */
         inputMethodHints: Qt.ImhSensitiveData
     }
 
@@ -70,8 +68,6 @@
             Keys.onReturnPressed: {
                 main.processForm();
             }
-            KeyNavigation.tab: emailTextField
-            KeyNavigation.backtab: passwordTextField
         }
 
         Label {

=== modified file 'online-accounts-provider/NewAccount.qml'
--- online-accounts-provider/NewAccount.qml	2016-03-21 14:48:41 +0000
+++ online-accounts-provider/NewAccount.qml	2016-11-03 17:00:00 +0000
@@ -79,8 +79,6 @@
         width: main.width - (2 * main.anchors.margins)
         validator: RegExpValidator { regExp: /.+@.+/ }
         focus: true
-        KeyNavigation.tab: state == "login" ? passwordTextField : registerForm.nameTextField
-        KeyNavigation.backtab: state == "login" ? (twoFactorVisible ? twoFactorTextField : passwordTextField) : registerForm.confirmPasswordTextField
         inputMethodHints: Qt.ImhEmailCharactersOnly
         anchors.left: parent.left
         anchors.right: parent.right

=== modified file 'online-accounts-provider/RegisterForm.qml'
--- online-accounts-provider/RegisterForm.qml	2016-03-21 14:48:41 +0000
+++ online-accounts-provider/RegisterForm.qml	2016-11-03 17:00:00 +0000
@@ -39,8 +39,6 @@
         objectName: "nameTextField"
         placeholderText: i18n.dtr(rootFlickable.domain, "First and last name")
         width: main.width - (2 * main.anchors.margins)
-        KeyNavigation.tab: newPasswordTextField
-        KeyNavigation.backtab: emailTextField
         onLengthChanged: {
             if (nameTextField.length > 0) {
                 validateInput();
@@ -59,8 +57,6 @@
         placeholderText: i18n.dtr(rootFlickable.domain, "At least 8 characters")
         echoMode: TextInput.Password
         width: main.width - (2 * main.anchors.margins)
-        KeyNavigation.tab: confirmPasswordTextField
-        KeyNavigation.backtab: nameTextField
         inputMethodHints: Qt.ImhSensitiveData
         onLengthChanged: {
             if (newPasswordTextField.length > 0) {
@@ -75,8 +71,6 @@
         placeholderText: i18n.dtr(rootFlickable.domain, "Must match the previous field")
         echoMode: TextInput.Password
         width: main.width - (2 * main.anchors.margins)
-        KeyNavigation.tab: emailTextField
-        KeyNavigation.backtab: newPasswordTextField
         inputMethodHints: Qt.ImhSensitiveData
         onLengthChanged: {
             if (confirmPasswordTextField.length > 0) {