Merge lp:~dobey/ubuntuone-control-panel/no-msg-menu into lp:ubuntuone-control-panel

Proposed by dobey on 2012-11-15
Status: Merged
Approved by: dobey on 2012-11-30
Approved revision: 383
Merged at revision: 386
Proposed branch: lp:~dobey/ubuntuone-control-panel/no-msg-menu
Merge into: lp:ubuntuone-control-panel
Diff against target: 39 lines (+2/-5)
2 files modified
setup.py (+2/-4)
ubuntuone-control-panel.in (+0/-1)
To merge this branch: bzr merge lp:~dobey/ubuntuone-control-panel/no-msg-menu
Reviewer Review Type Date Requested Status
Mike McCracken (community) 2012-11-15 Approve on 2012-11-26
Review via email: mp+134467@code.launchpad.net

Commit Message

Remove messaging menu integration file.

To post a comment you must log in.
Mike McCracken (mikemc) wrote :

Looks good.

review: Approve
Ubuntu One Auto Pilot (otto-pilot) wrote :
Download full text (192.6 KiB)

The attempt to merge lp:~dobey/ubuntuone-control-panel/no-msg-menu into lp:ubuntuone-control-panel failed. Below is the output from the failed tests.

*** Running DBus test suite ***
ubuntuone.controlpanel.dbustests.test_dbus_service
  BaseTestCase
    runTest ... [OK]
  DBusServiceMainTestCase
    test_dbus_service_cant_register ... Control panel backend already running.
                                   [OK]
    test_dbus_service_main ... [OK]
  DBusServiceTestCase
    test_cant_register_twice ... [SKIPPED]
    test_dbus_busname_created ... [OK]
    test_error_handler_default ... [OK]
    test_error_handler_with_exception ... [OK]
    test_error_handler_with_failure ... [OK]
    test_error_handler_with_non_string_dict ... [OK]
    test_error_handler_with_string_dict ... [OK]
    test_register_service ... [OK]
  FileSyncTestCase
    test_file_sync_status_changed ... [OK]
    test_file_sync_status_disabled ... [OK]
    test_file_sync_status_disconnected ... [OK]
    test_file_sync_status_error ... [OK]
    test_file_sync_status_idle ... [OK]
    test_file_sync_status_starting ... [OK]
    test_file_sync_status_stopped ... [OK]
    test_file_sync_status_syncing ... [OK]
    test_file_sync_status_unknown ... [OK]
    test_status_changed_handler ... [OK]
    test_status_changed_handler_after_status_requested ... [OK]
    test_status_changed_handler_after_status_requested_twice ... [OK]
  OperationsAuthErrorTestCase
    test_account_info_returned ... [OK]
    test_change_device_settings ... [OK]
    test_change_replication_settings ... [OK]
    test_change_volume_settings ... [OK]
    test_connect_files ... [OK]
    test_devices_info_returned ... [OK]
    test_disable_files ... [OK]
    test_disconnect_files ... [OK]
    test_enable_files ... [OK]
    test_remove_device ... [OK]
    test_replications_info ... [OK]
    test_restart_files ... [OK]
    test_start_...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2012-05-24 18:59:58 +0000
3+++ setup.py 2012-11-15 13:45:28 +0000
4@@ -39,11 +39,10 @@
5
6 POT_FILE = 'po/ubuntuone-control-panel.pot'
7 SERVICE_FILE = 'com.ubuntuone.controlpanel.service'
8-MESSAGE_ENTRY = 'ubuntuone-control-panel'
9 CONSTANTS = 'ubuntuone/controlpanel/constants.py'
10
11 CLEANFILES = [
12- SERVICE_FILE, MESSAGE_ENTRY, CONSTANTS, POT_FILE,
13+ SERVICE_FILE, CONSTANTS, POT_FILE,
14 'MANIFEST']
15 QT_UI_DIR = os.path.join('ubuntuone', 'controlpanel', 'gui', 'qt', 'ui')
16
17@@ -51,7 +50,7 @@
18 def replace_prefix(prefix):
19 """Replace every '@prefix@' with prefix within 'filename' content."""
20 # replace .service file, DATA_DIR constant
21- for filename in (SERVICE_FILE, MESSAGE_ENTRY, CONSTANTS):
22+ for filename in (SERVICE_FILE, CONSTANTS):
23 with open(filename + '.in') as in_file:
24 content = in_file.read()
25 with open(filename, 'w') as out_file:
26@@ -217,7 +216,6 @@
27 ('lib/ubuntuone-control-panel',
28 ['bin/ubuntuone-control-panel-backend']),
29 ('share/dbus-1/services/', [SERVICE_FILE]),
30- ('share/indicators/messages/applications/', [MESSAGE_ENTRY]),
31 ('share/apport/package-hooks/',
32 ['data/source_ubuntuone-control-panel.py']),
33 ],
34
35=== removed file 'ubuntuone-control-panel.in'
36--- ubuntuone-control-panel.in 2011-09-16 14:37:20 +0000
37+++ ubuntuone-control-panel.in 1970-01-01 00:00:00 +0000
38@@ -1,1 +0,0 @@
39-@prefix@/share/applications/ubuntuone-installer.desktop

Subscribers

People subscribed via source and target branches

to all changes: