Merge lp:~dobey/ubuntuone-control-panel/no-gb-val into lp:ubuntuone-control-panel

Proposed by dobey
Status: Merged
Approved by: Natalia Bidart
Approved revision: 213
Merged at revision: 213
Proposed branch: lp:~dobey/ubuntuone-control-panel/no-gb-val
Merge into: lp:ubuntuone-control-panel
Diff against target: 43 lines (+3/-28)
1 file modified
data/gtk/overview.ui (+3/-28)
To merge this branch: bzr merge lp:~dobey/ubuntuone-control-panel/no-gb-val
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+74228@code.launchpad.net

Commit message

Don't show the "Get NGB free!" label on "Join now" button at all

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/gtk/overview.ui'
2--- data/gtk/overview.ui 2011-07-11 11:19:09 +0000
3+++ data/gtk/overview.ui 2011-09-06 14:30:20 +0000
4@@ -251,36 +251,11 @@
5 <property name="use_action_appearance">False</property>
6 <signal name="clicked" handler="on_join_now_button_clicked" swapped="no"/>
7 <child>
8- <object class="GtkVBox" id="vbox4">
9+ <object class="GtkLabel" id="label1">
10 <property name="visible">True</property>
11 <property name="can_focus">False</property>
12- <property name="spacing">5</property>
13- <child>
14- <object class="GtkLabel" id="label1">
15- <property name="visible">True</property>
16- <property name="can_focus">False</property>
17- <property name="label" translatable="yes">&lt;span font_size="xx-large" foreground="#4d4d4d"&gt;Join now&lt;/span&gt;</property>
18- <property name="use_markup">True</property>
19- </object>
20- <packing>
21- <property name="expand">True</property>
22- <property name="fill">True</property>
23- <property name="position">0</property>
24- </packing>
25- </child>
26- <child>
27- <object class="GtkLabel" id="label2">
28- <property name="visible">True</property>
29- <property name="can_focus">False</property>
30- <property name="label" translatable="yes">&lt;span foreground="#909090"&gt;2GB of free storage&lt;/span&gt;</property>
31- <property name="use_markup">True</property>
32- </object>
33- <packing>
34- <property name="expand">True</property>
35- <property name="fill">True</property>
36- <property name="position">1</property>
37- </packing>
38- </child>
39+ <property name="label" translatable="yes">&lt;span font_size="xx-large" foreground="#4d4d4d"&gt;Join now&lt;/span&gt;</property>
40+ <property name="use_markup">True</property>
41 </object>
42 </child>
43 </object>

Subscribers

People subscribed via source and target branches

to all changes: