Merge lp:~dobey/ubuntuone-client/oauth-log-fixes into lp:ubuntuone-client
Proposed by
dobey
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Guillermo Gonzalez | ||||
Approved revision: | 241 | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~dobey/ubuntuone-client/oauth-log-fixes | ||||
Merge into: | lp:ubuntuone-client | ||||
Diff against target: |
164 lines 5 files modified
bin/ubuntuone-client-applet (+3/-5) ubuntuone/oauthdesktop/auth.py (+14/-14) ubuntuone/oauthdesktop/logger.py (+17/-3) ubuntuone/oauthdesktop/main.py (+1/-3) ubuntuone/syncdaemon/logger.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~dobey/ubuntuone-client/oauth-log-fixes | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guillermo Gonzalez | Approve | ||
Rick McBride (community) | Approve | ||
Review via email: mp+13017@code.launchpad.net |
Commit message
Rotate the oauth log and cap at 1MB
Change a few logger.debug messages to logger.error
Clean up the usage of callback_error in the oauth process
To post a comment you must log in.
Other than the below, this looks good.
== Python Lint Notices ==
./ubuntuone/ oauthdesktop/ auth.py:
261: undefined name 'e'