Merge lp:~dobey/ubuntuone-client/notification-icon-size into lp:ubuntuone-client

Proposed by dobey
Status: Merged
Approved by: Rick McBride
Approved revision: 215
Merged at revision: not available
Proposed branch: lp:~dobey/ubuntuone-client/notification-icon-size
Merge into: lp:ubuntuone-client
Diff against target: None lines
To merge this branch: bzr merge lp:~dobey/ubuntuone-client/notification-icon-size
Reviewer Review Type Date Requested Status
Rick McBride (community) Approve
Rodrigo Moya (community) Approve
Review via email: mp+11927@code.launchpad.net

Commit message

Change the notification icon size to 48 instead of 24

To post a comment you must log in.
Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

Looks good

review: Approve
Revision history for this message
Rick McBride (rmcbride) wrote :

I like simple to review/test branches. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubuntuone-client-applet'
2--- bin/ubuntuone-client-applet 2009-09-14 21:01:03 +0000
3+++ bin/ubuntuone-client-applet 2009-09-16 19:56:06 +0000
4@@ -64,6 +64,8 @@
5 OAUTH_CONSUMER = "ubuntuone"
6 BOOKMARK_NAME = "Ubuntu One"
7
8+NOTIFY_ICON_SIZE = 48
9+
10 # Why thank you GTK+ for enforcing style-set and breaking API
11 RCSTYLE = """
12 style 'dialogs' {
13@@ -462,7 +464,7 @@
14 _("Updating files..."),
15 _("Ubuntu One is now updating your files."))
16 pixbuf = self.__theme.load_icon(
17- "ubuntuone-client", 24,
18+ "ubuntuone-client", NOTIFY_ICON_SIZE,
19 gtk.ICON_LOOKUP_GENERIC_FALLBACK)
20 n.set_icon_from_pixbuf(pixbuf)
21 n.show()
22@@ -492,7 +494,7 @@
23 self.__total = 0
24 self.__updating = 0
25 pixbuf = self.__theme.load_icon(
26- "ubuntuone-client", 24,
27+ "ubuntuone-client", NOTIFY_ICON_SIZE,
28 gtk.ICON_LOOKUP_GENERIC_FALLBACK)
29 n.set_icon_from_pixbuf(pixbuf)
30 n.show()
31@@ -562,7 +564,7 @@
32 "A new version of the server should be accessible "
33 "soon. Please be patient while we update."))
34 pixbuf = self.__theme.load_icon(
35- "ubuntuone-client-error", 24,
36+ "ubuntuone-client-error", NOTIFY_ICON_SIZE,
37 gtk.ICON_LOOKUP_GENERIC_FALLBACK)
38 n.set_icon_from_pixbuf(pixbuf)
39 n.set_urgency(pynotify.URGENCY_CRITICAL)
40@@ -621,7 +623,7 @@
41 "Please click on the Ubuntu One icon " +
42 "in your panel to report a bug."))
43 pixbuf = self.__theme.load_icon(
44- "ubuntuone-client-error", 24,
45+ "ubuntuone-client-error", NOTIFY_ICON_SIZE,
46 gtk.ICON_LOOKUP_GENERIC_FALLBACK)
47 n.set_icon_from_pixbuf(pixbuf)
48 n.set_urgency(pynotify.URGENCY_CRITICAL)

Subscribers

People subscribed via source and target branches