Merge lp:~dobey/ubuntuone-client/apport-newonly-2-0 into lp:ubuntuone-client/stable-2-0

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 1147
Merged at revision: 1148
Proposed branch: lp:~dobey/ubuntuone-client/apport-newonly-2-0
Merge into: lp:ubuntuone-client/stable-2-0
Diff against target: 68 lines (+2/-29)
1 file modified
data/source_ubuntuone-client.py (+2/-29)
To merge this branch: bzr merge lp:~dobey/ubuntuone-client/apport-newonly-2-0
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+101936@code.launchpad.net

Commit message

Don't attach old useless log files, and clean up the report a little

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/source_ubuntuone-client.py'
2--- data/source_ubuntuone-client.py 2011-02-09 14:40:29 +0000
3+++ data/source_ubuntuone-client.py 2012-04-13 17:08:56 +0000
4@@ -1,6 +1,6 @@
5 # Apport integration for Ubuntu One client
6 #
7-# Copyright 2009 Canonical Ltd.
8+# Copyright 2009-2012 Canonical Ltd.
9 #
10 # This program is free software: you can redistribute it and/or modify it
11 # under the terms of the GNU General Public License version 3, as published
12@@ -17,7 +17,7 @@
13 # pylint: disable-msg=F0401,C0103
14 # shut up about apport. We know. We aren't going to backport it for pqm
15 import apport
16-from apport.hookutils import attach_file_if_exists, packaging
17+from apport.hookutils import attach_file_if_exists
18 import os.path
19 from xdg.BaseDirectory import xdg_cache_home, xdg_config_home
20
21@@ -28,11 +28,8 @@
22 u1_client_log = os.path.join(u1_log_path, "syncdaemon.log")
23 u1_except_log = os.path.join(u1_log_path, "syncdaemon-exceptions.log")
24 u1_invalidnames_log = os.path.join(u1_log_path, "syncdaemon-invalid-names.log")
25-u1_oauth_log = os.path.join(u1_log_path, "oauth-login.log")
26-u1_prefs_log = os.path.join(u1_log_path, "u1-prefs.log")
27 u1_sd_conf = os.path.join("etc", "xdg", "ubuntuone", "syncdaemon.conf")
28 u1_usersd_conf = os.path.join(u1_user_config_path, "syncdaemon.conf")
29-u1_user_conf = os.path.join(u1_user_config_path, "ubuntuone-client.conf")
30
31
32 def add_info(report):
33@@ -41,35 +38,11 @@
34 "UbuntuOneSyncdaemonExceptionsLog")
35 attach_file_if_exists(report, u1_invalidnames_log,
36 "UbuntuOneSyncdaemonInvalidNamesLog")
37- attach_file_if_exists(report, u1_oauth_log,
38- "UbuntuOneOAuthLoginLog")
39- attach_file_if_exists(report, u1_prefs_log,
40- "UbuntuOnePreferencesLog")
41 attach_file_if_exists(report, u1_usersd_conf,
42 "UbuntuOneUserSyncdaemonConfig")
43 attach_file_if_exists(report, u1_sd_conf,
44 "UbuntuOneSyncdaemonConfig")
45- attach_file_if_exists(report, u1_user_conf,
46- "UbuntuOneClientConfig")
47
48 if not apport.packaging.is_distro_package(report['Package'].split()[0]):
49 report['ThirdParty'] = 'True'
50 report['CrashDB'] = 'ubuntuone'
51-
52- packages = ['ubuntuone-client',
53- 'python-ubuntuone-client',
54- 'ubuntuone-client-tools',
55- 'ubuntuone-client-gnome',
56- 'python-ubuntuone-storageprotocol',
57- 'ubuntuone-ppa-beta']
58-
59- versions = ''
60- for package in packages:
61- try:
62- version = packaging.get_version(package)
63- except ValueError:
64- version = 'N/A'
65- if version is None:
66- version = 'N/A'
67- versions += '%s %s\n' % (package, version)
68- report['UbuntuOneClientPackages'] = versions

Subscribers

People subscribed via source and target branches

to all changes: