Merge lp:~dobey/ubuntuone-client-gnome/migrate-launcher into lp:ubuntuone-client-gnome

Proposed by dobey
Status: Rejected
Rejected by: dobey
Proposed branch: lp:~dobey/ubuntuone-client-gnome/migrate-launcher
Merge into: lp:ubuntuone-client-gnome
Diff against target: 27 lines (+17/-0)
1 file modified
gsd/gsd-ubuntuone.c (+17/-0)
To merge this branch: bzr merge lp:~dobey/ubuntuone-client-gnome/migrate-launcher
Reviewer Review Type Date Requested Status
Roman Yepishev (community) Needs Information
Review via email: mp+78003@code.launchpad.net

Commit message

Replace control-panel .desktop in unity favs with installer's .desktop

To post a comment you must log in.
Revision history for this message
Roman Yepishev (rye) wrote :

Blocking on:

Didier Roche (didrocks) wrote 2 hours ago:

I guess that changing the gsettings key won't work. The unity launcher doesn't support pick update gsettings string and it can be overwritten then if you move or pin a new launcher icon.

review: Needs Information

Unmerged revisions

7. By dobey

Replace control-panel .desktop in unity favs with installer's .desktop

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gsd/gsd-ubuntuone.c'
2--- gsd/gsd-ubuntuone.c 2011-09-23 15:31:01 +0000
3+++ gsd/gsd-ubuntuone.c 2011-10-03 20:39:28 +0000
4@@ -185,6 +185,23 @@
5 gsd_ubuntuone_activate (GnomeSettingsPlugin *gsp_object)
6 {
7 GsdUbuntuOne *plugin = GSD_UBUNTUONE (gsp_object);
8+#ifdef HAVE_GSD_30
9+ GSettings *settings;
10+ gchar ** launchers;
11+ int iter;
12+
13+ settings = g_settings_new ("com.canonical.Unity.Launcher");
14+ launchers = g_settings_get_strv (settings, "favorites");
15+ for (iter = 0; launchers[iter] != NULL; iter++) {
16+ if (!g_strcmp0 (launchers[iter], "ubuntuone-control-panel-gtk.desktop")) {
17+ g_free (launchers[iter]);
18+ launchers[iter] = g_strdup ("ubuntuone-installer.desktop");
19+ }
20+ }
21+ g_settings_set_strv (settings, "favorites", (const gchar * const *) launchers);
22+ g_strfreev (launchers);
23+ g_object_unref (settings);
24+#endif
25
26 g_timeout_add (DELAYED_START_TIMEOUT, delayed_syncdaemon_start, plugin);
27 }

Subscribers

People subscribed via source and target branches

to all changes: