Merge lp:~dobey/ubuntuone-client-gnome/list-expand into lp:ubuntuone-client-gnome

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 4
Merged at revision: 4
Proposed branch: lp:~dobey/ubuntuone-client-gnome/list-expand
Merge into: lp:ubuntuone-client-gnome
Diff against target: 46 lines (+11/-12)
1 file modified
nautilus/share-dialog.c (+11/-12)
To merge this branch: bzr merge lp:~dobey/ubuntuone-client-gnome/list-expand
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Review via email: mp+76467@code.launchpad.net

Commit message

Be more explicit about expanding since GTK+ 3.x broke this

To post a comment you must log in.
Revision history for this message
Manuel de la Peña (mandel) wrote :

Would be nice to rename the var fro table to vbox, but is not an issue therefore I approve it and let dobey decide.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nautilus/share-dialog.c'
2--- nautilus/share-dialog.c 2011-07-20 20:44:39 +0000
3+++ nautilus/share-dialog.c 2011-09-21 19:28:16 +0000
4@@ -116,31 +116,30 @@
5 (_("Share")), GTK_RESPONSE_ACCEPT,
6 NULL);
7 gtk_dialog_set_default_response (GTK_DIALOG (dialog), GTK_RESPONSE_ACCEPT);
8- gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog), GTK_RESPONSE_ACCEPT, FALSE);
9+ gtk_dialog_set_response_sensitive (GTK_DIALOG (dialog),
10+ GTK_RESPONSE_ACCEPT, FALSE);
11 gtk_window_set_icon_name (GTK_WINDOW (dialog), "ubuntuone");
12 g_signal_connect (G_OBJECT (dialog), "response",
13 G_CALLBACK (dialog_response_cb), NULL);
14
15 area = gtk_dialog_get_content_area (GTK_DIALOG (dialog));
16
17- table = gtk_table_new (3, 2, FALSE);
18- gtk_table_set_row_spacings (GTK_TABLE (table), 12);
19- gtk_table_set_col_spacings (GTK_TABLE (table), 6);
20- gtk_container_set_border_width (GTK_CONTAINER (table), 7);
21- gtk_widget_show (table);
22- gtk_container_add (GTK_CONTAINER (area), table);
23+ table = gtk_vbox_new (FALSE, 12);
24+ gtk_container_set_border_width (GTK_CONTAINER (table), 7);
25+ gtk_box_pack_start (GTK_BOX (area), table, TRUE, TRUE, 0);
26+ gtk_widget_show (table);
27
28 dialog->user_picker = u1_contacts_picker_new ();
29 g_signal_connect (G_OBJECT (dialog->user_picker), "selection-changed",
30 G_CALLBACK (picker_selection_changed_cb), dialog);
31- gtk_table_attach (GTK_TABLE (table), dialog->user_picker, 0, 2, 0, 2,
32- GTK_FILL | GTK_EXPAND | GTK_SHRINK,
33- GTK_FILL | GTK_EXPAND | GTK_SHRINK, 3, 3);
34+ gtk_box_pack_start (GTK_BOX (table), dialog->user_picker, TRUE, TRUE, 0);
35 gtk_widget_show (dialog->user_picker);
36
37 dialog->allow_mods = gtk_check_button_new_with_mnemonic (_("_Allow Modification"));
38- gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (dialog->allow_mods), TRUE); /* Default to RW */
39- gtk_table_attach (GTK_TABLE (table), dialog->allow_mods, 0, 2, 2, 3, GTK_FILL, GTK_FILL, 3, 3);
40+ /* Default to RW */
41+ gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (dialog->allow_mods),
42+ TRUE);
43+ gtk_box_pack_end (GTK_BOX (table), dialog->allow_mods, FALSE, FALSE, 0);
44 gtk_widget_show (dialog->allow_mods);
45
46 gtk_widget_set_size_request (GTK_WIDGET (dialog), 500, 450);

Subscribers

People subscribed via source and target branches

to all changes: