Ubuntu Single Sign On Client

Code review comment for lp:~dobey/ubuntu-sso-client/new-kr-props

  1. new-kr-props
  2. Merge into trunk
Revision history for this message
Alejandro J. Cura (alecu) wrote :

The code looks very good. Some comments:

 * Please change CLXN to COLLECTION for consistency, even if the constants are not exported.
 * why did you change the out_signature of SecretServiceMock.CreateCollection? I'm looking here, and it's still a "o", but perhaps it's changed on gnome-keyring 3: http://code.confuego.org/secrets-xdg-specs/re01.html

review: Needs Fixing

« Back to merge proposal