Merge lp:~dobey/ubuntu-purchase-service/fix-tests into lp:ubuntu-purchase-service

Proposed by dobey on 2014-03-06
Status: Merged
Approved by: dobey on 2014-03-07
Approved revision: 17
Merged at revision: 16
Proposed branch: lp:~dobey/ubuntu-purchase-service/fix-tests
Merge into: lp:ubuntu-purchase-service
Diff against target: 20 lines (+2/-2)
2 files modified
.bzrignore (+1/-1)
src/tests/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~dobey/ubuntu-purchase-service/fix-tests
Reviewer Review Type Date Requested Status
Roberto Alsina (community) 2014-03-06 Approve on 2014-03-07
PS Jenkins bot continuous-integration Approve on 2014-03-06
Review via email: mp+209699@code.launchpad.net

Commit message

Use 'env' to set the environment for qml unit tests.
Add build/ directory to the ignore list.

To post a comment you must log in.
Roberto Alsina (ralsina) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2013-12-17 15:15:25 +0000
3+++ .bzrignore 2014-03-06 14:16:25 +0000
4@@ -20,4 +20,4 @@
5
6 Ubuntu
7 qmldir
8-
9+build/
10
11=== modified file 'src/tests/CMakeLists.txt'
12--- src/tests/CMakeLists.txt 2014-01-10 19:14:43 +0000
13+++ src/tests/CMakeLists.txt 2014-03-06 14:16:25 +0000
14@@ -1,6 +1,6 @@
15 set(XVFB_CMD xvfb-run -a -s "-screen 0 640x480x24")
16 add_custom_target (qmlunit-tests
17- COMMAND QML2_IMPORT_PATH=${CMAKE_CURRENT_BINARY_DIR}/.. ${XVFB_CMD} qmltestrunner -input ${CMAKE_CURRENT_SOURCE_DIR}/qml
18+ COMMAND env QML2_IMPORT_PATH=${CMAKE_CURRENT_BINARY_DIR}/.. ${XVFB_CMD} qmltestrunner -input ${CMAKE_CURRENT_SOURCE_DIR}/qml
19 DEPENDS ${QML_PLUGIN_NAME}
20 )
21

Subscribers

People subscribed via source and target branches

to all changes: