Ubuntu Application Launcher

Merge lp:~dobey/ubuntu-app-launch/build-parallel into lp:ubuntu-app-launch/16.10

  1. build-parallel
  2. Merge into trunk.16.10
Proposed by dobey
Status: Merged
Approved by: Ted Gould
Approved revision: 232
Merged at revision: 232
Proposed branch: lp:~dobey/ubuntu-app-launch/build-parallel
Merge into: lp:ubuntu-app-launch/16.10
Diff against target: 23 lines (+4/-2)
2 files modified
debian/rules (+2/-1)
debian/ubuntu-app-launch-tools.install (+2/-1)
To merge this branch: bzr merge lp:~dobey/ubuntu-app-launch/build-parallel
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
unity-api-1-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Pending
Review via email: mp+299696@code.launchpad.net

Commit message

Use stricter gensymbols check.
Build with parallel and fail on missing files.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:231
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/8/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/126/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/134
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/81
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/81
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/81
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/64/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/64/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/64/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/64/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/64/console
    ABORTED: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/64/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/64/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/64/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/64/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/8/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:231
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/10/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/229/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/237
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/178
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/178
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/178
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/107/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/107/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/107/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/107/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/107/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/107/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/107/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/107/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/107/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/10/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

LGTM, I don't think we're using the symbols check but it won't hurt to have it there.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/rules'
2--- debian/rules 2016-02-08 22:09:12 +0000
3+++ debian/rules 2016-07-27 15:00:40 +0000
4@@ -6,9 +6,10 @@
5
6 # Uncomment this to turn on verbose mode.
7 #export DH_VERBOSE=1
8+export DPKG_GENSYMBOLS_CHECK_LEVEL=4
9
10 %:
11- dh $@ --with click,gir
12+ dh $@ --with click,gir --parallel --fail-missing
13
14 override_dh_click:
15 dh_click --name ubuntu-app-launch-desktop
16
17=== modified file 'debian/ubuntu-app-launch-tools.install'
18--- debian/ubuntu-app-launch-tools.install 2015-02-23 17:51:44 +0000
19+++ debian/ubuntu-app-launch-tools.install 2016-07-27 15:00:40 +0000
20@@ -1,1 +1,2 @@
21-usr/bin/ubuntu-app*
22+usr/bin/ubuntu-app-*
23+usr/bin/ubuntu-helper-*

Subscribers

People subscribed via source and target branches