Merge lp:~dobey/u1sync/fix-api-break into lp:u1sync

Proposed by dobey on 2012-06-18
Status: Merged
Approved by: dobey on 2012-06-18
Approved revision: 5
Merged at revision: 5
Proposed branch: lp:~dobey/u1sync/fix-api-break
Merge into: lp:u1sync
Diff against target: 26 lines (+3/-4)
2 files modified
run-tests (+2/-3)
u1sync/client.py (+1/-1)
To merge this branch: bzr merge lp:~dobey/u1sync/fix-api-break
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve on 2012-06-18
Manuel de la Peña (community) 2012-06-18 Approve on 2012-06-18
Review via email: mp+110827@code.launchpad.net

Commit Message

Fix to work with the new storage-protocol API to validate hostname properly

To post a comment you must log in.
review: Approve
Roberto Alsina (ralsina) :
review: Approve
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/u1sync/fix-api-break into lp:u1sync failed. Below is the output from the failed tests.

./run-tests: line 19: u1trial: command not found

Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/u1sync/fix-api-break into lp:u1sync failed. Below is the output from the failed tests.

                                                                        [ERROR]
u1sync.tests.test_merge
  MergeTest
    test_clobber ... [OK]
    test_generic_merge ... [OK]
    test_sync ... [OK]

===============================================================================
[ERROR]: u1sync.tests.test_client

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/trial/runner.py", line 563, in loadPackage
    module = modinfo.load()
  File "/usr/lib/python2.6/dist-packages/twisted/python/modules.py", line 381, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.6/dist-packages/twisted/python/reflect.py", line 464, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/mnt/tarmac/cache/u1sync/trunk/u1sync/tests/test_client.py", line 20, in <module>
    from mocker import Mocker
exceptions.ImportError: No module named mocker
-------------------------------------------------------------------------------
Ran 3 tests in 0.181s

FAILED (errors=1, successes=3)

Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/u1sync/fix-api-break into lp:u1sync failed. Below is the output from the failed tests.

                                                                        [ERROR]
u1sync.tests.test_merge
  MergeTest
    test_clobber ... [OK]
    test_generic_merge ... [OK]
    test_sync ... [OK]

===============================================================================
[ERROR]: u1sync.tests.test_client

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/trial/runner.py", line 563, in loadPackage
    module = modinfo.load()
  File "/usr/lib/python2.6/dist-packages/twisted/python/modules.py", line 381, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.6/dist-packages/twisted/python/reflect.py", line 464, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/mnt/tarmac/cache/u1sync/trunk/u1sync/tests/test_client.py", line 23, in <module>
    from u1sync import client
  File "/mnt/tarmac/cache/u1sync/trunk/u1sync/client.py", line 35, in <module>
    from ubuntuone.platform.xdg_base_directory import ubuntuone_log_dir
exceptions.ImportError: No module named platform.xdg_base_directory
-------------------------------------------------------------------------------
Ran 3 tests in 0.008s

FAILED (errors=1, successes=3)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'run-tests'
2--- run-tests 2011-02-09 17:46:32 +0000
3+++ run-tests 2012-06-18 14:28:18 +0000
4@@ -16,8 +16,7 @@
5 # with this program. If not, see <http://www.gnu.org/licenses/>.
6 set -e
7
8-u1trial -c u1sync
9-USE_PYFLAKES=1 u1lint
10+trial u1sync
11+pyflakes u1sync bin/u1sync
12 rm -rf _trial_temp
13-rm -rf .coverage
14
15
16=== modified file 'u1sync/client.py'
17--- u1sync/client.py 2011-09-01 12:48:57 +0000
18+++ u1sync/client.py 2012-06-18 14:28:18 +0000
19@@ -325,7 +325,7 @@
20 """Connect to host/port using ssl."""
21 def _connect():
22 """deferred part."""
23- ctx = get_ssl_context(no_verify)
24+ ctx = get_ssl_context(no_verify, host)
25 self.reactor.connectSSL(host, port, self.factory, ctx)
26 self._connect_inner(_connect)
27

Subscribers

People subscribed via source and target branches

to all changes: