Merge lp:~dobey/tarmac/list-approved into lp:tarmac

[dobey]

Add a --list-approved option to the merge command.

With this, running "tarmac merge lp:foo --list-approved" will print out the list of MP URLs for all branches approved for merging into lp:foo. With "tarmac merge --list-approved" omitting the specific branch target, tarmac will print all approved branches for merging into all target branches specified in the tarmac.conf file.

[David Britton (dpb)]

[0] typo on docstring for test:

   *Test* that *--list-approved* option prints..

Looks good! +1

review: Approve

[lp:~dobey/tarmac/list-approved]

428. By dobey on 2014-02-18

Fix typos.

[Francis Ginther (fginther)]

This should resolve part 1 of the feature request as documented in the bug.

+1

review: Approve

=== modified file 'tarmac/bin/commands.py'
--- tarmac/bin/commands.py	2013-12-05 22:28:15 +0000
+++ tarmac/bin/commands.py	2014-02-18 23:18:12 +0000
@@ -1,3 +1,18 @@
+# Copyright 2009-2012 Paul Hummer
+# Copyright 2009-2014 Canonical Ltd.
+#
+# Tarmac is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by
+# the Free Software Foundation.
+#
+# Tarmac is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Tarmac.  If not, see <http://www.gnu.org/licenses/>.
 '''Command handling for Tarmac.'''
 import httplib2
 import logging
@@ -158,7 +173,9 @@
         options.http_debug_option,
         options.debug_option,
         options.imply_commit_message_option,
-        options.one_option]
+        options.one_option,
+        options.list_approved_option,
+    ]
 
     def _handle_merge_error(self, proposal, failure):
         """Handle TarmacMergeError cases from _do_merges."""
@@ -200,6 +217,11 @@
                     'branch_url': branch_url})
             return
 
+        if self.config.list_approved:
+            for proposal in proposals:
+                print(get_review_url(proposal))
+            return
+
         try:
             target = Branch.create(lp_branch, self.config, create_tree=True,
                                    launchpad=self.launchpad)

=== modified file 'tarmac/bin/options.py'
--- tarmac/bin/options.py	2012-05-26 04:14:45 +0000
+++ tarmac/bin/options.py	2014-02-18 23:18:12 +0000
@@ -1,3 +1,18 @@
+# Copyright 2010-2011 Paul Hummer
+# Copyright 2010-2014 Canonical Ltd.
+#
+# Tarmac is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by
+# the Free Software Foundation.
+#
+# Tarmac is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Tarmac.  If not, see <http://www.gnu.org/licenses/>.
 '''Command options.'''
 from bzrlib.option import Option
 
@@ -18,3 +33,6 @@
 one_option = Option(
     'one', short_name='1',
     help='Merge only one branch and exit.')
+list_approved_option = Option(
+    'list-approved', short_name='l',
+    help='List Approved merge proposals for the target branch.')

=== modified file 'tarmac/tests/test_commands.py'
--- tarmac/tests/test_commands.py	2014-01-09 21:40:25 +0000
+++ tarmac/tests/test_commands.py	2014-02-18 23:18:12 +0000
@@ -449,6 +449,13 @@
         self.assertEqual(self.error.comment,
                          invalid_tree_comment)
 
+    @patch('tarmac.bin.commands.get_review_url')
+    def test_run_merge_with_list_approved_option(self, mocked):
+        """Test that --list-approved option prints a list and returns."""
+        self.addProposal('list_approved')
+        self.command.run(launchpad=self.launchpad, list_approved=True)
+        self.assertEqual(mocked.call_count, 2)
+
     def test__compare_proposals(self):
         """
         _compare_proposals is meant to be a sort routine comparison function