Merge lp:~dobey/tarmac/fix-633937 into lp:tarmac

Proposed by dobey
Status: Merged
Approved by: Paul Hummer
Approved revision: 356
Merged at revision: 358
Proposed branch: lp:~dobey/tarmac/fix-633937
Merge into: lp:tarmac
Diff against target: 14 lines (+6/-1)
1 file modified
tarmac/bin/commands.py (+6/-1)
To merge this branch: bzr merge lp:~dobey/tarmac/fix-633937
Reviewer Review Type Date Requested Status
Paul Hummer Approve
Review via email: mp+35717@code.launchpad.net

Commit message

Trap and log all exceptions from _do_merges when looping through all branches

To post a comment you must log in.
Revision history for this message
Paul Hummer (rockstar) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tarmac/bin/commands.py'
2--- tarmac/bin/commands.py 2010-09-02 15:18:07 +0000
3+++ tarmac/bin/commands.py 2010-09-16 18:56:09 +0000
4@@ -287,4 +287,9 @@
5 self.logger.debug(
6 'Merging approved branches against %(branch)s' % {
7 'branch': branch})
8- self._do_merges(branch, imply_commit_message)
9+ try:
10+ self._do_merges(branch, imply_commit_message)
11+ except Exception, error:
12+ self.logger.error(
13+ 'An error occurred trying to merge %s: %s',
14+ branch, error)

Subscribers

People subscribed via source and target branches