Merge lp:~dobey/software-center/fix-typeerror into lp:software-center

Proposed by dobey on 2013-11-18
Status: Merged
Approved by: dobey on 2013-11-18
Approved revision: 3319
Merged at revision: 3319
Proposed branch: lp:~dobey/software-center/fix-typeerror
Merge into: lp:software-center
Diff against target: 13 lines (+2/-1)
1 file modified
softwarecenter/ui/gtk3/panes/availablepane.py (+2/-1)
To merge this branch: bzr merge lp:~dobey/software-center/fix-typeerror
Reviewer Review Type Date Requested Status
Mike McCracken (community) 2013-11-18 Approve on 2013-11-18
Review via email: mp+195611@code.launchpad.net

Commit message

Only add the launcher when the desktop file is not None.

To post a comment you must log in.
Mike McCracken (mikemc) wrote :

looks fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/panes/availablepane.py'
2--- softwarecenter/ui/gtk3/panes/availablepane.py 2013-09-10 16:26:42 +0000
3+++ softwarecenter/ui/gtk3/panes/availablepane.py 2013-11-18 14:00:46 +0000
4@@ -437,7 +437,8 @@
5 trans_id != PURCHASE_TRANSACTION_ID and
6 config.add_to_unity_launcher and
7 softwarecenter.utils.is_unity_running()):
8- self._add_application_to_unity_launcher(details)
9+ if details.desktop_file is not None:
10+ self._add_application_to_unity_launcher(details)
11
12 def on_transaction_cancelled(self, backend, result):
13 """ handle a transaction that has been cancelled

Subscribers

People subscribed via source and target branches