Merge lp:~dobey/indicator-sound/drop-greeeter into lp:indicator-sound
Status: | Approved |
---|---|
Approved by: | dobey on 2017-03-24 |
Approved revision: | 552 |
Proposed branch: | lp:~dobey/indicator-sound/drop-greeeter |
Merge into: | lp:indicator-sound |
Diff against target: |
867 lines (+4/-697) 11 files modified
debian/control (+0/-1) src/CMakeLists.txt (+2/-20) src/accounts-service-user.vala (+0/-47) src/greeter-broadcast.vala (+0/-34) src/main.c (+2/-6) src/media-player-list-greeter.vala (+0/-123) src/media-player-user.vala (+0/-18) src/service.vala (+0/-9) tests/CMakeLists.txt (+0/-51) tests/greeter-list.cc (+0/-68) tests/media-player-user.cc (+0/-320) |
To merge this branch: | bzr merge lp:~dobey/indicator-sound/drop-greeeter |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
unity-api-1-bot | continuous-integration | Approve on 2017-03-30 | |
Charles Kerr (community) | 2017-03-23 | Approve on 2017-03-23 | |
Review via email:
|
Commit message
Strip out the complicated non-working greeter support.
Description of the change
This removes the code which theoretically proxies the player controls out to the greeter screen, that doesn't work.
The Sound menu spec states that the player controls should NOT appear on the greeter screen:
https:/
"Whenever you are logged in (that is, not in the standalone installer session or at the login screen), any music player that advertises itself over http://
Charles Kerr (charlesk) wrote : | # |
So, first off, I'm not super happy with the tone of the MR, e.g. "theoretically". If the code needs fixing then that's something that should be addressed, but bugs happen and there's no need to be snide about it.
Secondly, I still disagree with the removal of this feature. Controlling play from the greeter is a worthwhile feature IMO.
But as per the discussion in the Indicator meeting today, I'm in the minority on this. If neither the coder doing the work, NOR the designer, want this feature, I'm not going to block the change. :P
unity-api-1-bot (unity-api-1-bot) wrote : | # |
PASSED: Continuous integration, rev:552
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
FAILED: Continuous integration, rev:552 /jenkins. canonical. com/unity- api-1/job/ lp-indicator- sound-ci/ 14/ /jenkins. canonical. com/unity- api-1/job/ build/1858/ console /jenkins. canonical. com/unity- api-1/job/ build-0- fetch/1865 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1641/console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= zesty/1641/ console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1641/console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= zesty/1641/ console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1641/console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= zesty/1641/ console
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/unity- api-1/job/ lp-indicator- sound-ci/ 14/rebuild
https:/