Merge lp:~dobey/indicator-network/lib-recommends into lp:indicator-network/15.10
| Status: | Merged |
|---|---|
| Approved by: | Pete Woods on 2016-01-27 |
| Approved revision: | 557 |
| Merged at revision: | 560 |
| Proposed branch: | lp:~dobey/indicator-network/lib-recommends |
| Merge into: | lp:indicator-network/15.10 |
| Diff against target: |
11 lines (+1/-1) 1 file modified
debian/control (+1/-1) |
| To merge this branch: | bzr merge lp:~dobey/indicator-network/lib-recommends |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing on 2016-01-19 | |
| Michał Sawicz | conceptual | 2016-01-19 | Approve on 2016-01-19 |
|
Review via email:
|
|||
Commit Message
Change the dependency on indicator-network to a Recommends.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:557
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| dobey (dobey) wrote : | # |
> WFM, what will happen if it's not there, though? Will the lib "work" without
> the indicator?
If it doesn't return appropriate error conditions without, it's a bug in the library. Recommends still pulls it in by default in the default apt config on Ubuntu though. And it pulls it into seeds, if anything seeded Recommends something. But it's obviously not necessary to be running the indicator during builds. If you do need to actually run the indicator, then you should be also installing the native indicator package in cross-compiles (but you can't run any built test binaries in that situation anyway, without emulation).
| Michał Sawicz (saviq) wrote : | # |
W dniu 19.01.2016 o 17:06, Rodney Dawes pisze:
> If it doesn't return appropriate error conditions without, it's a bug in the library. Recommends still pulls it in by default in the default apt config on Ubuntu though. And it pulls it into seeds, if anything seeded Recommends something. But it's obviously not necessary to be running the indicator during builds. If you do need to actually run the indicator, then you should be also installing the native indicator package in cross-compiles (but you can't run any built test binaries in that situation anyway, without emulation).
Oh yeah, sure, we're not relying on it in builds/tests, just asking.
WFM, what will happen if it's not there, though? Will the lib "work" without the indicator?