Merge lp:~dobey/indicator-keyboard/no-more-autostart into lp:indicator-keyboard

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 1218
Merged at revision: 1221
Proposed branch: lp:~dobey/indicator-keyboard/no-more-autostart
Merge into: lp:indicator-keyboard
Diff against target: 91 lines (+1/-43)
6 files modified
configure.ac (+0/-1)
data/Makefile.am (+0/-12)
data/indicator-keyboard.desktop.in (+0/-9)
data/upstart/Makefile.am (+0/-12)
data/upstart/indicator-keyboard.desktop.in (+0/-9)
debian/indicator-keyboard.maintscript (+1/-0)
To merge this branch: bzr merge lp:~dobey/indicator-keyboard/no-more-autostart
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
unity-api-1-bot continuous-integration Approve
Review via email: mp+316374@code.launchpad.net

Commit message

Remove the xdg autostart files.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :
review: Needs Fixing (continuous-integration)
1218. By dobey

Remove from configure.ac too.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:1218
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-keyboard-ci/3/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1601
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1608
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1386
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1386/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1386
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1386/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1386
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1386/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1386
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1386/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1386
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1386/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1386
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1386/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-keyboard-ci/3/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2016-10-21 10:16:26 +0000
3+++ configure.ac 2017-02-03 22:28:14 +0000
4@@ -62,7 +62,6 @@
5
6 AC_CONFIG_FILES([Makefile
7 data/Makefile
8- data/upstart/Makefile
9 lib/Makefile
10 po/Makefile.in
11 tests/Makefile
12
13=== modified file 'data/Makefile.am'
14--- data/Makefile.am 2016-07-19 08:16:29 +0000
15+++ data/Makefile.am 2017-02-03 22:28:14 +0000
16@@ -1,6 +1,4 @@
17
18-SUBDIRS = upstart
19-
20 ###########################
21 # Icon Generator
22 ###########################
23@@ -50,16 +48,6 @@
24 $(AM_V_GEN) sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
25
26 ###########################
27-# XDG Autostart File
28-###########################
29-
30-xdg_autostartdir = /etc/xdg/autostart
31-xdg_autostart_DATA = indicator-keyboard.desktop
32-
33-%.desktop: %.desktop.in
34- $(AM_V_GEN) sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
35-
36-###########################
37 # Systemd configuration
38 ###########################
39
40
41=== removed file 'data/indicator-keyboard.desktop.in'
42--- data/indicator-keyboard.desktop.in 2014-02-26 16:35:15 +0000
43+++ data/indicator-keyboard.desktop.in 1970-01-01 00:00:00 +0000
44@@ -1,9 +0,0 @@
45-[Desktop Entry]
46-Type=Application
47-Name=Indicator Keyboard
48-Exec=@pkglibexecdir@/indicator-keyboard-service
49-OnlyShowIn=Unity;GNOME;
50-NoDisplay=true
51-StartupNotify=false
52-Terminal=false
53-AutostartCondition=GNOME3 unless-session gnome
54
55=== removed directory 'data/upstart'
56=== removed file 'data/upstart/Makefile.am'
57--- data/upstart/Makefile.am 2014-02-20 04:39:39 +0000
58+++ data/upstart/Makefile.am 1970-01-01 00:00:00 +0000
59@@ -1,12 +0,0 @@
60-###########################
61-# Upstart XDG Override
62-###########################
63-
64-xdg_autostartdir = $(datadir)/upstart/xdg/autostart
65-xdg_autostart_DATA = indicator-keyboard.desktop
66-
67-%.desktop: %.desktop.in
68- $(AM_V_GEN) sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
69-
70-EXTRA_DIST = indicator-keyboard.desktop.in
71-
72
73=== removed file 'data/upstart/indicator-keyboard.desktop.in'
74--- data/upstart/indicator-keyboard.desktop.in 2014-02-20 04:40:34 +0000
75+++ data/upstart/indicator-keyboard.desktop.in 1970-01-01 00:00:00 +0000
76@@ -1,9 +0,0 @@
77-[Desktop Entry]
78-Type=Application
79-Name=Indicator Keyboard
80-Exec=@pkglibexecdir@/indicator-keyboard-service
81-OnlyShowIn=Unity;
82-NoDisplay=true
83-StartupNotify=false
84-Terminal=false
85-Hidden=true
86
87=== added file 'debian/indicator-keyboard.maintscript'
88--- debian/indicator-keyboard.maintscript 1970-01-01 00:00:00 +0000
89+++ debian/indicator-keyboard.maintscript 2017-02-03 22:28:14 +0000
90@@ -0,0 +1,1 @@
91+rm_conffile /etc/xdg/autostart/indicator-keyboard.desktop 0replaceme~

Subscribers

People subscribed via source and target branches

to all changes: