Merge lp:~dobey/indicator-datetime/no-more-autostart into lp:indicator-datetime

Proposed by dobey
Status: Merged
Approved by: Charles Kerr
Approved revision: 473
Merged at revision: 477
Proposed branch: lp:~dobey/indicator-datetime/no-more-autostart
Merge into: lp:indicator-datetime
Diff against target: 86 lines (+1/-60)
4 files modified
data/CMakeLists.txt (+0/-41)
data/indicator-datetime.desktop.in (+0/-10)
data/indicator-datetime.upstart.desktop.in (+0/-9)
debian/indicator-datetime.maintscript (+1/-0)
To merge this branch: bzr merge lp:~dobey/indicator-datetime/no-more-autostart
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
unity-api-1-bot continuous-integration Approve
Review via email: mp+316372@code.launchpad.net

Commit message

Remove old autostart .desktop files.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:473
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-datetime-ci/16/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1599
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1606
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1384
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1384/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1384
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1384/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1384
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1384/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1384
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1384/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1384
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1384/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1384
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1384/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-datetime-ci/16/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/CMakeLists.txt'
2--- data/CMakeLists.txt 2016-07-19 07:58:21 +0000
3+++ data/CMakeLists.txt 2017-02-03 20:20:43 +0000
4@@ -69,47 +69,6 @@
5 DESTINATION "${UPSTART_JOB_DIR}")
6
7 ##
8-## XDG Autostart File
9-##
10-
11-# where to install
12-set (XDG_AUTOSTART_DIR "/etc/xdg/autostart")
13-message (STATUS "${XDG_AUTOSTART_DIR} is the DBus Service File install dir")
14-
15-set (XDG_AUTOSTART_NAME "${CMAKE_PROJECT_NAME}.desktop")
16-set (XDG_AUTOSTART_FILE "${CMAKE_CURRENT_BINARY_DIR}/${XDG_AUTOSTART_NAME}")
17-set (XDG_AUTOSTART_FILE_IN "${CMAKE_CURRENT_SOURCE_DIR}/${XDG_AUTOSTART_NAME}.in")
18-
19-# build it
20-set (pkglibexecdir "${CMAKE_INSTALL_FULL_PKGLIBEXECDIR}")
21-configure_file ("${XDG_AUTOSTART_FILE_IN}" "${XDG_AUTOSTART_FILE}")
22-
23-# install XDG autostart
24-install (FILES "${XDG_AUTOSTART_FILE}"
25- DESTINATION "${XDG_AUTOSTART_DIR}")
26-
27-##
28-## Upstart XDG Autostart Override
29-##
30-
31-# where to install
32-set (UPSTART_XDG_AUTOSTART_DIR "${CMAKE_INSTALL_FULL_DATAROOTDIR}/upstart/xdg/autostart")
33-message (STATUS "${UPSTART_XDG_AUTOSTART_DIR} is the Upstart XDG autostart override dir")
34-
35-set (UPSTART_XDG_AUTOSTART_NAME "${CMAKE_PROJECT_NAME}.upstart.desktop")
36-set (UPSTART_XDG_AUTOSTART_FILE "${CMAKE_CURRENT_BINARY_DIR}/${UPSTART_XDG_AUTOSTART_NAME}")
37-set (UPSTART_XDG_AUTOSTART_FILE_IN "${CMAKE_CURRENT_SOURCE_DIR}/${UPSTART_XDG_AUTOSTART_NAME}.in")
38-
39-# build it
40-set (pkglibexecdir "${CMAKE_INSTALL_FULL_PKGLIBEXECDIR}")
41-configure_file ("${UPSTART_XDG_AUTOSTART_FILE_IN}" "${UPSTART_XDG_AUTOSTART_FILE}")
42-
43-# install it
44-install (FILES "${UPSTART_XDG_AUTOSTART_FILE}"
45- DESTINATION "${UPSTART_XDG_AUTOSTART_DIR}"
46- RENAME "${XDG_AUTOSTART_NAME}")
47-
48-##
49 ## Unity Indicator File
50 ##
51
52
53=== removed file 'data/indicator-datetime.desktop.in'
54--- data/indicator-datetime.desktop.in 2016-05-14 02:07:10 +0000
55+++ data/indicator-datetime.desktop.in 1970-01-01 00:00:00 +0000
56@@ -1,10 +0,0 @@
57-[Desktop Entry]
58-Type=Application
59-Name=Indicator Date & Time
60-Exec=@pkglibexecdir@/indicator-datetime-service
61-OnlyShowIn=Unity;GNOME;Pantheon;
62-NoDisplay=true
63-StartupNotify=false
64-Terminal=false
65-AutostartCondition=GNOME3 unless-session gnome
66-Icon=@messaging_menu_icon@
67
68=== removed file 'data/indicator-datetime.upstart.desktop.in'
69--- data/indicator-datetime.upstart.desktop.in 2014-02-20 04:04:20 +0000
70+++ data/indicator-datetime.upstart.desktop.in 1970-01-01 00:00:00 +0000
71@@ -1,9 +0,0 @@
72-[Desktop Entry]
73-Type=Application
74-Name=Indicator Date & Time
75-Exec=@pkglibexecdir@/indicator-datetime-service
76-OnlyShowIn=Unity;
77-NoDisplay=true
78-StartupNotify=false
79-Terminal=false
80-Hidden=true
81
82=== added file 'debian/indicator-datetime.maintscript'
83--- debian/indicator-datetime.maintscript 1970-01-01 00:00:00 +0000
84+++ debian/indicator-datetime.maintscript 2017-02-03 20:20:43 +0000
85@@ -0,0 +1,1 @@
86+rm_conffile /etc/xdg/autostart/indicator-datetime.desktop 0replaceme~

Subscribers

People subscribed via source and target branches