UTAH

Merge lp:~doanac/utah/logcat-chroot into lp:utah

  1. logcat-chroot
  2. Merge into dev
Proposed by Andy Doan
Status: Merged
Merged at revision: 1016
Proposed branch: lp:~doanac/utah/logcat-chroot
Merge into: lp:utah
Diff against target: 13 lines (+2/-1)
1 file modified
examples/run_utah_phablet.py (+2/-1)
To merge this branch: bzr merge lp:~doanac/utah/logcat-chroot
Reviewer Review Type Date Requested Status
Paul Larson Approve
Joe Talbott (community) Approve
Review via email: mp+187063@code.launchpad.net

Description of the change

stop using android-chroot to run logcat

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote :

LGTM

review: Approve
Revision history for this message
Paul Larson (pwlars) wrote :

Ogra mentioned that he intends to remove the command completely, so we should probably rip it out all the way, along with the unit tests for it. Otherwise it'll just be dead code. Otherwise +1

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

i've fixed pauls comment in my merge commit.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/run_utah_phablet.py'
2--- examples/run_utah_phablet.py 2013-09-19 16:37:17 +0000
3+++ examples/run_utah_phablet.py 2013-09-23 16:18:19 +0000
4@@ -142,7 +142,8 @@
5 with open(ofile, 'w') as f:
6 f.write(buf)
7
8- buf = device.run_android('logcat -d', False)
9+ buf = device.run_ubuntu(
10+ '/var/lib/lxc/android/rootfs/system/bin/logcat -d', False)
11 ofile = os.path.join(results_dir, 'logcat.log')
12 with open(ofile, 'w') as f:
13 f.write(buf)

Subscribers

People subscribed via source and target branches

to all changes: