lp:~doanac/uci-engine/runner-refactor

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:uci-engine

Vincent Ladeuil (community): Disapprove on 2014-07-11

PS Jenkins bot (community): Approve (continuous-integration) on 2014-07-10

Diff: 442 lines (+213/-135)

4 files modified

test_runner/tstrun/run_worker.py (+13/-134)
test_runner/tstrun/testbed.py (+137/-1)
test_runner/tstrun/tests/test_testbed.py (+31/-0)
test_runner/tstrun/tests/test_worker.py (+32/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

665. By Andy Doan on 2014-07-10

test-runner: simplify run-worker code

The handle_request function was growing too large to debug. It also
was written in a way that made it hard to test with a simple CLI like
we have for the image-builder.

This refactors things so that its easier to test the actual runner w/o
needing anything from rabbit.

664. By Andy Doan on 2014-07-10

[r=Celso Providelo, PS Jenkins bot] restish charm: reorganize code layout and improve install logic

This does a couple of things that were hard to do piece by piece. The
change is a bit big but:

The main goal was getting our code to be in its own directory so it
can start to be treated like read-only. We have an idea in the future
of code rollbacks, so this fits in with that model. This now deploys
code to:

 /srv/<service>/code/r<revno>_<sha1>

 and we maintain a symlink to the latest code with:

   /srv/<service>/code/current

While doing this I got rid of all the bzr-branch logic we no longer
use. This reduces complexity.

I'll also converted our tarball logic to use charmhelpers.fetch.

While changing so much, I also decided to improve our code-extraction
logic by moving it to our config-changed logic. This means that
we now have the ability to update code by just changing the payload
value of the service.

663. By Andy Doan on 2014-07-10

[r=Celso Providelo, PS Jenkins bot] test-runner: convert to using unit-config

Originally our project had no common way to load the unit-config. We
now do and should convert our components to all use it.

Additionally - we are about to change code layout structure in production
and our unit-config module knows how to find it.

662. By Robert Bruce Park on 2014-07-09

[r=PS Jenkins bot, Robert Bruce Park] Instruct users how to run web_static locally with live production db data.

661. By Robert Bruce Park on 2014-07-09

[r=Robert Bruce Park, PS Jenkins bot] Instruct users how to run web_static locally with live production db data.

660. By Andy Doan on 2014-07-09

[r=Celso Providelo, Evan Dandrea, PS Jenkins bot] unit-config: allow discovery with new code layout

The new code layout will be like:

 /srv/<service>/
                 unit_config
        /code/current/<code>

659. By Andy Doan on 2014-07-09

[r=Celso Providelo, PS Jenkins bot] test-runner: use default worker health check

  I wrote this to also check the health of glance. However, I noticed in
production/hpcloud that we don't have the glance client installed:

 ImportError: No module named glanceclient

So this code path doesn't need testing

658. By Andy Doan on 2014-07-09

[r=PS Jenkins bot, Francis Ginther, Celso Providelo] lander charm: reorganize code layout and improve install logic

This does a couple of things that were hard to do piece by piece. The
change is a bit big but:

The main goal was getting our code to be in its own directory so it
can start to be treated like read-only. We have an idea in the future
of code rollbacks, so this fits in with that model. This now deploys
code to:

 /srv/<service>/code/r<revno>_<sha1>

 and we maintain a symlink to the latest code with:

  /srv/<service>/code/current

While doing this I got rid of all the bzr-branch logic we no longer
use. This reduces complexity.

I'll also converted our tarball logic to use charmhelpers.fetch.

While changing so much, I also decided to improve our code-extraction
logic by moving it to our config-changed logic. This means that
we now have the ability to update code by just changing the payload
value of the service.

657. By Andy Doan on 2014-07-09

[r=Paul Larson, PS Jenkins bot] bsbuilder: fix TODO for unit_config from Andy Doan

656. By Evan on 2014-07-09

[r=PS Jenkins bot, Vincent Ladeuil] Get the path correct for testing.venv in called-by-tarmac. Fix a pep8 issue. from Evan Dandrea