Code review comment for lp:~doanac/ubuntu-ci-services-itself/imgbuild-kernel-fixes

Revision history for this message
Evan (ev) wrote :

57 + _chrooted(chroot, 'apt-get install -y {}'.format(' '.join(pkglist)))

We have all the apt keys imported and the cache updated, yes? I'm typing this from my iPad, otherwise I'd check myself.

139 +image_size: 4G

Can we have a comment documenting what this does and why it's set to 4G?

Otherwise +1. Good stuff.

Have you checked with Paul on why we had those dpkg's options set in the first place?

review: Approve

« Back to merge proposal