Merge lp:~doanac/linaro-android-build-tools/lava-test-plan-repeats into lp:linaro-android-build-tools

Proposed by Andy Doan
Status: Merged
Approved by: Paul Sokolovsky
Approved revision: 398
Merged at revision: 399
Proposed branch: lp:~doanac/linaro-android-build-tools/lava-test-plan-repeats
Merge into: lp:linaro-android-build-tools
Diff against target: 13 lines (+2/-1)
1 file modified
build-scripts/post-build-lava.py (+2/-1)
To merge this branch: bzr merge lp:~doanac/linaro-android-build-tools/lava-test-plan-repeats
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+89991@code.launchpad.net

Description of the change

I'd like to be able to run a LAVA test more than once after a build like:
  LAVA_TEST_PLAN=v8,v8,v8,skia,skia,skia

Here's an example build:
 https://android-build.linaro.org/builds/~doanac/tracking-panda-google4.4/#build=2

However, the job definition:
 http://validation.linaro.org/lava-server/scheduler/job/9946/definition

winds up with the lava_android_test_insall command repeating the tests names which causes errors and not all tests to get executed. This *should* fix the issue, but I'm not sure how to unit test it.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-scripts/post-build-lava.py'
2--- build-scripts/post-build-lava.py 2011-12-16 13:57:21 +0000
3+++ build-scripts/post-build-lava.py 2012-01-24 20:10:32 +0000
4@@ -52,7 +52,8 @@
5 inst_action = {
6 "command": "lava_android_test_install",
7 "parameters": {
8- "tests": tests
9+ # ensure only unique test names
10+ "tests": list(set(tests))
11 }
12 }
13 actions.append(inst_action)

Subscribers

People subscribed via source and target branches