Merge lp:~doanac/lava-test/stream-md5 into lp:lava-test/0.0

Proposed by Andy Doan
Status: Rejected
Rejected by: Zygmunt Krynicki
Proposed branch: lp:~doanac/lava-test/stream-md5
Merge into: lp:lava-test/0.0
Diff against target: 12 lines (+1/-1)
1 file modified
abrek/test_definitions/stream.py (+1/-1)
To merge this branch: bzr merge lp:~doanac/lava-test/stream-md5
Reviewer Review Type Date Requested Status
Paul Larson (community) Disapprove
Review via email: mp+49452@code.launchpad.net

Description of the change

The MD5 of:
 http://www.cs.virginia.edu/stream/FTP/Code/stream.c

has changed. We need to update this in our stream.py so that the
test will be installable.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

I actually fixed this while we were talking about it, and just removed the md5 check on it for now since I don't see a good way to point at a specific version of stream on their download site. So the version in trunk should work now already. Thanks though.

review: Disapprove
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I'd like to propose that we fork stream and keep downloads available on launchpad. I hate stuff like this done by upstream. I'll open a bug report on this.

Unmerged revisions

57. By Andy Doan

updated md5 for stream.c

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'abrek/test_definitions/stream.py'
2--- abrek/test_definitions/stream.py 2010-08-18 15:33:32 +0000
3+++ abrek/test_definitions/stream.py 2011-02-11 19:21:29 +0000
4@@ -16,7 +16,7 @@
5 import abrek.testdef
6
7 URL="http://www.cs.virginia.edu/stream/FTP/Code/stream.c"
8-MD5="b6cd43b848e0d8b0824703369392f3c5"
9+MD5="851f8f1f81f9dc339ad425ff7affa29b"
10 INSTALLSTEPS = ['cc stream.c -O2 -fopenmp -o stream']
11 RUNSTEPS = ['./stream']
12 PATTERN = "^(?P<test_case_id>\w+):\W+(?P<measurement>\d+\.\d+)"

Subscribers

People subscribed via source and target branches