Code review comment for lp:~doanac/lava-lab/lava-scripts

Revision history for this message
Antonio Terceiro (terceiro) wrote :

This looks awesome!

One general comment: you don't need to run l-d-t as root. I did the following
on the vagrant-bootstrap script inside the l-d-t repo:

if ! test -d /srv/lava/instances/development; then
  cd $basedir
  su vagrant -c './lava-deployment-tool setup -nd'
  su vagrant -c './lava-deployment-tool install -nd development'

so you could do something like that, and you won't need to chown/chmod away, or
even add that check on l-d-t to allow running as root.

Antonio Terceiro
Software Engineer - Linaro

« Back to merge proposal