Merge lp:~doanac/charms/precise/ubuntu-ci-services-itself/lander-image-builder-start into lp:~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/lander
Proposed by
Andy Doan
Status: | Merged |
---|---|
Approved by: | Francis Ginther |
Approved revision: | 30 |
Merged at revision: | 28 |
Proposed branch: | lp:~doanac/charms/precise/ubuntu-ci-services-itself/lander-image-builder-start |
Merge into: | lp:~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/lander |
Diff against target: |
43 lines (+19/-0) 1 file modified
templates/jobs/lander_master.xml (+19/-0) |
To merge this branch: | bzr merge lp:~doanac/charms/precise/ubuntu-ci-services-itself/lander-image-builder-start |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Francis Ginther | Approve | ||
Review via email: mp+202759@code.launchpad.net |
Description of the change
This adds relations for the image builder and provides some scaffolding so it actually builds something.
To post a comment you must log in.
I'm not too familiar with what lander_ merge_parameter s does, but if this is just supposed to be some sane values that should work as a quick test, that seems fine to me. Does it need to wait and see the end status for it? Does it need to do cleanup or anything? Every time you run this, you'll get a new copy of the image out in glance. I ask, because at least my personal account seems to have some limitations on the space, I got an error today that it was out of space.