~dmzoneill/charm-advanced-routing:dev/upgrade

Branch merges

Propose for merging

Ready for review for merging into ~dmzoneill/charm-advanced-routing:master

Jeremy Lounder (community): Approve on 2020-03-25

Drew Freiberger (community): Needs Fixing on 2019-08-28

David O Neill: Pending requested 2019-08-27

Diff: 1956 lines (+1785/-0)

28 files modified

.gitignore (+12/-0)
LICENSE (+202/-0)
Makefile (+49/-0)
README (+0/-0)
README.md (+49/-0)
config.yaml (+17/-0)
example_config.yaml (+27/-0)
icon.svg (+279/-0)
interfaces/.empty (+1/-0)
layer.yaml (+2/-0)
layers/.empty (+1/-0)
lib/AdvancedRoutingHelper.py (+132/-0)
lib/RoutingEntry.py (+221/-0)
lib/RoutingValidator.py (+182/-0)
metadata.yaml (+16/-0)
reactive/advanced_routing.py (+56/-0)
requirements.txt (+3/-0)
revision (+1/-0)
tests/bundles/bionic.yaml (+45/-0)
tests/bundles/overlays/bionic.yaml.j2 (+2/-0)
tests/functional/conftest.py (+71/-0)
tests/functional/juju_tools.py (+69/-0)
tests/functional/requirements.txt (+6/-0)
tests/functional/test_routing.py (+54/-0)
tests/unit/conftest.py (+80/-0)
tests/unit/requirements.txt (+8/-0)
tests/unit/test_AdvancedRoutingHelper.py (+154/-0)
tox.ini (+46/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

25b0cd4... by David O Neill on 2019-08-28

Fixes and improvements from review 371884 MR

https://code.launchpad.net/~dmzoneill/charm-advanced-routing/+git/charm-advanced-routing/+merge/371884

 * replaced format for all string formatting
 * replaced exits with raise exception
 * solved a bug of duplicate entries in ip/down script
 * numerous of code tidy ups and best practices
 * linted it
 * updates for unit and functional testing

2a2c57d... by David O Neill on 2019-08-26

Migrate from hooks to reactive based charm

Upgraded to reactive and added static routing

 - Upgraded charm to reactive
 - Cleaned up old libraries
 - Add parser, extensibility to different routing, table, rule configuration options
 - Change to json blob in juju config item
 - Added multiple sanity checks and verification + better juju logging
 - Added functionality testing with libjuju

  expected config: based on example_config.yaml

  root@juju-720cde-24:/home/ubuntu# cat /etc/iproute2/rt_tables.d/juju-managed.conf
  100 SF1

  root@juju-720cde-24:/home/ubuntu# cat /usr/local/sbin/if-down/95-juju_routing
  # This file is managed by Juju.
  sudo ip rule del from 192.170.2.0/24 to 192.170.2.0/24 lookup SF1
  sudo ip route del 6.6.6.0/24 via 10.191.86.2
  sudo ip route del default via 10.191.86.2 table SF1 dev eth0
  sudo ip route flush table SF1
  sudo ip rule del table SF1
  sudo ip route flush cache

  root@juju-720cde-24:/home/ubuntu# cat /usr/local/sbin/if-up/95-juju_routing
  # This file is managed by Juju.
  sudo ip route flush cache
  # Table: name SF1
  sudo ip route replace default via 10.191.86.2 table SF1 dev eth0
  sudo ip route replace 6.6.6.0/24 via 10.191.86.2
  sudo ip rule add from 192.170.2.0/24 to 192.170.2.0/24 lookup SF1

Co-authored-by: Diko Parvanov <email address hidden>