Merge lp:~dmj726/humanity/hidpi-2x into lp:~ubuntu-art-pkg/humanity/release
Proposed by
David Jordan
on 2017-01-19
| Status: | Superseded | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Proposed branch: | lp:~dmj726/humanity/hidpi-2x | ||||||||
| Merge into: | lp:~ubuntu-art-pkg/humanity/release | ||||||||
| Diff against target: |
1095 lines (+570/-0) 3 files modified
Humanity-Dark/index.theme (+126/-0) Humanity/index.theme (+438/-0) debian/changelog (+6/-0) |
||||||||
| To merge this branch: | bzr merge lp:~dmj726/humanity/hidpi-2x | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Iain Lane | 2017-01-19 | Needs Fixing on 2017-01-22 | |
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2017-01-23.
Description of the Change
Adds @2x support for hidpi monitors.
Fixes:
https:/
https:/
To post a comment you must log in.
lp:~dmj726/humanity/hidpi-2x
updated
on 2017-01-23
- 127. By David Jordan on 2017-01-23
-
hidpi: use ScaledDirectories and change @2x to @2
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks, this is great! I knew about the problem but somehow it never got to the top of my list to fix, so I really appreciate this. Four mostly administrative/
- Please add the new entries to ScaledDirectories (see the spec[0]) instead of Directories.
- Please call the new directories "@2" instead of "@2x"; this is what we used for hidpi icons in the Ubuntu themes (for interface elements) - it would be good to be consistent with that. Not *super* important if you feel strongly about "@2x".
- If you agree, I think we should SRU these to at least 16.04 and 16.10 - could you please update the bug(s) to have the required SRU template information from [1]?
- Please write a changelog entry in debian/changelog (use `dch' and make sure $DEBFULLNAME and $DEBEMAIL are set in the environment - version for zesty should be 0.6.12), so you get properly credited.
[0] https:/
[1] https:/