Merge lp:~dmitriis/charms/trusty/contrail-webui/trunk into lp:~sdn-charmers/charms/trusty/contrail-webui/trunk

Proposed by Dmitrii Shcherbakov
Status: Rejected
Rejected by: Robert Ayres
Proposed branch: lp:~dmitriis/charms/trusty/contrail-webui/trunk
Merge into: lp:~sdn-charmers/charms/trusty/contrail-webui/trunk
Diff against target: 12 lines (+3/-1)
1 file modified
templates/contrail-webui-userauth.js (+3/-1)
To merge this branch: bzr merge lp:~dmitriis/charms/trusty/contrail-webui/trunk
Reviewer Review Type Date Requested Status
Ante Karamatić Pending
Review via email: mp+320152@code.launchpad.net

Description of the change

rbac support (rebased)

To post a comment you must log in.
Revision history for this message
Robert Ayres (robert-ayres) wrote :

Rejected - it seems from Contrail's own fab installer (3.2.3, Mitaka) 'cloud_admin_role' isn't read or required here.

Unmerged revisions

40. By Dmitrii Shcherbakov

add rbac relation data handling

The context is already pre-loaded with all relation data, therefore,
the only change required is in the template.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/contrail-webui-userauth.js'
2--- templates/contrail-webui-userauth.js 2016-11-14 20:48:45 +0000
3+++ templates/contrail-webui-userauth.js 2017-03-17 09:26:06 +0000
4@@ -7,6 +7,8 @@
5 auth.admin_user = '{{ identity_admin[0]['service_username'] }}';
6 auth.admin_password = '{{ identity_admin[0]['service_password'] }}';
7 auth.admin_tenant_name = '{{ identity_admin[0]['service_tenant_name'] }}';
8-
9+{% if contrail_api[0].get('rbac') -%}
10+auth.cloud_admin_role = '{{ contrail_api[0].get('cloud_admin_role') }}';
11+{% endif -%}
12 module.exports = auth;
13

Subscribers

People subscribed via source and target branches