Merge lp:~dmitriis/charms/trusty/contrail-analytics/trunk into lp:~sdn-charmers/charms/trusty/contrail-analytics/trunk

Proposed by Dmitrii Shcherbakov
Status: Merged
Merged at revision: 40
Proposed branch: lp:~dmitriis/charms/trusty/contrail-analytics/trunk
Merge into: lp:~sdn-charmers/charms/trusty/contrail-analytics/trunk
Diff against target: 60 lines (+23/-4)
3 files modified
hooks/contrail_analytics_hooks.py (+7/-1)
hooks/contrail_analytics_utils.py (+10/-3)
templates/contrail-analytics-api.conf (+6/-0)
To merge this branch: bzr merge lp:~dmitriis/charms/trusty/contrail-analytics/trunk
Reviewer Review Type Date Requested Status
Robert Ayres (community) Approve
Ante Karamatić Pending
Review via email: mp+320154@code.launchpad.net

Description of the change

rbac support (rebased)

To post a comment you must log in.
Revision history for this message
Robert Ayres (robert-ayres) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/contrail_analytics_hooks.py'
2--- hooks/contrail_analytics_hooks.py 2017-03-10 13:02:06 +0000
3+++ hooks/contrail_analytics_hooks.py 2017-03-17 09:27:51 +0000
4@@ -160,7 +160,13 @@
5
6 @hooks.hook("contrail-api-relation-changed")
7 def contrail_api_changed():
8- if not relation_get("port"):
9+ required_keys = ['port']
10+ # only need to check for role availability if
11+ # rbac is explicitly set
12+ if relation_get('rbac'):
13+ required_keys.append('cloud-admin-role')
14+
15+ if not all(relation_get(k) for k in required_keys):
16 log("Relation not ready")
17 return
18 contrail_api_relation()
19
20=== modified file 'hooks/contrail_analytics_utils.py'
21--- hooks/contrail_analytics_utils.py 2017-03-10 13:02:06 +0000
22+++ hooks/contrail_analytics_utils.py 2017-03-17 09:27:51 +0000
23@@ -113,10 +113,17 @@
24 def contrail_api_ctx():
25 ctxs = [ { "api_server": vip if vip \
26 else gethostbyname(relation_get("private-address", unit, rid)),
27- "api_port": port }
28+ "api_port": port,
29+ "rbac": rbac,
30+ "cloud_admin_role": adminrole
31+ }
32 for rid in relation_ids("contrail-api")
33- for unit, port, vip in
34- ((unit, relation_get("port", unit, rid), relation_get("vip", unit, rid))
35+ for unit, port, vip, rbac, adminrole in
36+ ((unit,
37+ relation_get("port", unit, rid),
38+ relation_get("vip", unit, rid),
39+ relation_get("rbac", unit, rid),
40+ relation_get("cloud-admin-role", unit, rid))
41 for unit in related_units(rid))
42 if port ]
43 return ctxs[0] if ctxs else {}
44
45=== modified file 'templates/contrail-analytics-api.conf'
46--- templates/contrail-analytics-api.conf 2017-01-31 12:44:08 +0000
47+++ templates/contrail-analytics-api.conf 2017-03-17 09:27:51 +0000
48@@ -17,6 +17,12 @@
49 api_server = {{ api_server ~ ":" ~ api_port if api_server and api_port }}
50 {%- endif %}
51
52+{% if rbac -%}
53+aaa_mode = no-auth
54+cloud_admin_role = {{ cloud_admin_role }}
55+
56+{% endif %}
57+
58 [DISCOVERY]
59 disc_server_ip = {{ disc_server_ip }}
60 disc_server_port = {{ disc_server_port }}

Subscribers

People subscribed via source and target branches