Merge lp:~dktrkranz/granite/non-linux-build into lp:~elementary-pantheon/granite/granite

Proposed by Luca Falavigna
Status: Merged
Approved by: Victor Martinez
Approved revision: 467
Merged at revision: 466
Proposed branch: lp:~dktrkranz/granite/non-linux-build
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 54 lines (+11/-1)
2 files modified
lib/Application.vala (+4/-0)
lib/CMakeLists.txt (+7/-1)
To merge this branch: bzr merge lp:~dktrkranz/granite/non-linux-build
Reviewer Review Type Date Requested Status
Victor Martinez (community) Approve
Devid Antonio Filoni (community) Needs Fixing
Review via email: mp+135765@code.launchpad.net

Description of the change

This new patch fixes a mistake I did in my previous patch

To post a comment you must log in.
Revision history for this message
Victor Martinez (victored) wrote :

I cannot test this on a non-linux system ATM, but the CMake-side implementation is reliable. Thanks for the quick fix!

review: Approve
Revision history for this message
Devid Antonio Filoni (d.filoni) wrote :

There is a typo on this patch:
 ${OS_TYPE)

review: Needs Fixing
Revision history for this message
Victor Martinez (victored) wrote :

Good catch Devid. I didn't see that ')' on line 21 (diff)

review: Needs Fixing
466. By Luca Falavigna

Fix typo

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Thanks, fixed.

467. By Luca Falavigna

Merge with trunk

Revision history for this message
Victor Martinez (victored) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Application.vala'
2--- lib/Application.vala 2012-11-23 01:19:02 +0000
3+++ lib/Application.vala 2012-11-23 08:52:30 +0000
4@@ -69,7 +69,9 @@
5
6 Granite.init ();
7 // set program name
8+#if LINUX
9 prctl (15, exec_name, 0, 0, 0);
10+#endif
11 Environment.set_prgname (exec_name);
12
13 Logger.initialize (program_name);
14@@ -86,8 +88,10 @@
15
16 }
17
18+#if LINUX
19 [CCode (cheader_filename = "sys/prctl.h", cname = "prctl")]
20 protected extern static int prctl (int option, string arg2, ulong arg3, ulong arg4, ulong arg5);
21+#endif
22
23 /**
24 * This method runs the application
25
26=== modified file 'lib/CMakeLists.txt'
27--- lib/CMakeLists.txt 2012-11-23 01:19:02 +0000
28+++ lib/CMakeLists.txt 2012-11-23 08:52:30 +0000
29@@ -44,6 +44,12 @@
30 ${DEPS_LIBRARY_DIRS}
31 )
32 link_directories(${LIB_PATHS})
33+
34+# Check whether OS type is Linux
35+if (CMAKE_SYSTEM_NAME MATCHES "Linux")
36+ set (OS_TYPE --define=LINUX)
37+endif ()
38+
39 #VALA stuff
40
41 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/Widgets/)
42@@ -96,6 +102,7 @@
43 gee-1.0
44 OPTIONS
45 --thread
46+ ${OS_TYPE}
47 GENERATE_VAPI
48 granite
49 GENERATE_HEADER
50@@ -148,4 +155,3 @@
51 add_custom_command (TARGET valadocs COMMAND rm ${CMAKE_CURRENT_BINARY_DIR}/images -R -f)
52 add_custom_command (TARGET valadocs COMMAND cp ${CMAKE_SOURCE_DIR}/doc/images/ ${CMAKE_CURRENT_BINARY_DIR}/images -R)
53 add_custom_command (TARGET valadocs COMMAND VALADOC_HEADER=${CMAKE_CURRENT_SOURCE_DIR}/docs/header.html valadoc -o docs_vala ${CMAKE_CURRENT_SOURCE_DIR}/*/*.vala ${CMAKE_CURRENT_SOURCE_DIR}/*.vapi ${CMAKE_CURRENT_SOURCE_DIR}/*.vala --pkg=glib-2.0 --pkg=gio-2.0 --pkg=posix --pkg=gtk+-3.0 --pkg=gee-1.0 --pkg=gio-unix-2.0 --package-name=${PKGNAME} --package-version=${GRANITE_VERSION} --force --doclet=html)
54-

Subscribers

People subscribed via source and target branches