Merge ~dkg0/dkimpy:argparse into dkimpy:master

Proposed by dkg
Status: Needs review
Proposed branch: ~dkg0/dkimpy:argparse
Merge into: dkimpy:master
Diff against target: 39 lines (+6/-4)
2 files modified
dkim/dkimverify.py (+3/-2)
man/dkimverify.1 (+3/-2)
Reviewer Review Type Date Requested Status
dkimpy developers Pending
Review via email: mp+392182@code.launchpad.net
To post a comment you must log in.

Unmerged commits

4938ad4... by dkg

dkimverify: handle -v (and --verbose) via argparse

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/dkim/dkimverify.py b/dkim/dkimverify.py
2index 2ca90d5..5001eb6 100644
3--- a/dkim/dkimverify.py
4+++ b/dkim/dkimverify.py
5@@ -32,6 +32,8 @@ def main():
6 parser = argparse.ArgumentParser(
7 description='Verify DKIM signature for email messages.',
8 epilog="message to be verified follows commands on stdin")
9+ parser.add_argument('-v', '--verbose', action='store_true',
10+ help='Show verbose information')
11 parser.add_argument('--index', metavar='N', type=int, default=0,
12 help='Index of DKIM signature header to verify: default=0')
13 args=parser.parse_args()
14@@ -40,8 +42,7 @@ def main():
15 sys.stdin = sys.stdin.detach()
16
17 message = sys.stdin.read()
18- verbose = '-v' in sys.argv
19- if verbose:
20+ if args.verbose:
21 import logging
22 d = dkim.DKIM(message, logger=logging)
23 else:
24diff --git a/man/dkimverify.1 b/man/dkimverify.1
25index 2b13d89..b523be3 100644
26--- a/man/dkimverify.1
27+++ b/man/dkimverify.1
28@@ -145,8 +145,9 @@ code 1.
29 usage: dkimverify.py [\-h] [\-\-index N] <message
30
31 optional arguments:
32- \-h, \-\-help show this help message and exit
33- \-\-index N Index of DKIM signature header to verify: default=0
34+ \-h, \-\-help show this help message and exit
35+ \-v, \-\-verbose provide more verbose output
36+ \-\-index N Index of DKIM signature header to verify: default=0
37
38 .SH "AUTHORS"
39 This version of \fBdkimverify\fR was written by Greg Hewgill <greg@hewgill.com>.

Subscribers

People subscribed via source and target branches

to all changes: