Merge lp:~dkessel/ubuntu-qa-website/fix-end-date-of-date-range-queries into lp:ubuntu-qa-website

[Daniel Kessel]

Fixes the last issue of bug 1126449 - the date range query generated now also includes the end date properly.

[Nicholas Skaggs (nskaggs)]

Nice! The php syntax for adding a day is different. P1D struck me as weird at first.

review: Approve

[Nicholas Skaggs (nskaggs)]

I will ask though, why do we need to go beyond the end date? Is the sql query the issue?

[Daniel Kessel (dkessel)]

Yes, the SQL query was the issue. The old statement was something like (example with today) "... AND date <= '2015/06/01'", which does not match datetime values like "2015/06/01 00:11:22". The new statement is something like "... AND date < '2015/06/02'", which will include all of today's results, but none of tomorrow's.

=== modified file 'modules/qatracker/report/qatracker.report.testers.php'
--- modules/qatracker/report/qatracker.report.testers.php	2012-11-19 20:35:32 +0000
+++ modules/qatracker/report/qatracker.report.testers.php	2015-05-31 14:59:28 +0000
@@ -54,7 +54,8 @@
         $query->condition('qatracker_result.date', DateTime::createFromFormat('m/d/Y', $_POST['date_from'])->format("Ymd"), ">=");
     }
     if(array_key_exists("date_to", $_POST) && $_POST['date_to']) {
-        $query->condition('qatracker_result.date', DateTime::createFromFormat('m/d/Y', $_POST['date_to'])->format("Ymd"), "<=");
+    	$day_after_date_to = DateTime::createFromFormat('m/d/Y', $_POST['date_to'])->add(new DateInterval("P1D"));
+        $query->condition('qatracker_result.date', $day_after_date_to->format("Ymd"), "<");
     }
     $query->orderBy('count', 'DESC');
     $query->condition('qatracker_milestone.siteid', $site->id);