Mail

Merge lp:~djaler1/pantheon-mail/fix-1547949 into lp:~elementary-apps/pantheon-mail/trunk

  1. fix-1547949
  2. Merge into trunk
Proposed by Kirill Romanov
Status: Merged
Approved by: Danielle Foré
Approved revision: 2085
Merged at revision: 2084
Proposed branch: lp:~djaler1/pantheon-mail/fix-1547949
Merge into: lp:~elementary-apps/pantheon-mail/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
src/client/components/main-toolbar.vala (+1/-0)
To merge this branch: bzr merge lp:~djaler1/pantheon-mail/fix-1547949
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+297635@code.launchpad.net

Commit message

Keep the toolbar from expanding by using Gtk.ResizeMode.QUEUE

Description of the change

Fix bug #1547949(Window-width GSetting has a very high value on first run)

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Just a minor code style issue, needs a space before ()

Can you also write a commit message?

I'm unable to reproduce the issue, but I've been unable to reproduce it previously as well :p Can you explain why this change fixes the issue just so I can feel good about merging it?

lp:~djaler1/pantheon-mail/fix-1547949 updated
2085. By Kirill Romanov

Fix bug #1547949(Window-width GSetting has a very high value on first run)
Setting MainToolbar resize mode to Queue.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/client/components/main-toolbar.vala'
2--- src/client/components/main-toolbar.vala 2016-03-13 02:38:34 +0000
3+++ src/client/components/main-toolbar.vala 2016-06-16 17:12:42 +0000
4@@ -30,6 +30,7 @@
5 public MainToolbar() {
6 show_close_button = true;
7 set_custom_title (new Gtk.Label (null)); //Set title as a null label so that it doesn't take up space
8+ set_resize_mode (Gtk.ResizeMode.QUEUE); //without this, toolbar rapidly expands and forces the window larger than the screen
9
10 folder_header = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 6);
11 conversation_header = new Gtk.Grid ();

Subscribers

People subscribed via source and target branches