Merge ~djacobs98/checkbox-provider-iiotg:djacobs98_qep into checkbox-provider-iiotg:main

Proposed by Doug Jacobs
Status: Needs review
Proposed branch: ~djacobs98/checkbox-provider-iiotg:djacobs98_qep
Merge into: checkbox-provider-iiotg:main
Diff against target: 35 lines (+21/-0)
2 files modified
units/qep/jobs.pxu (+4/-0)
units/qep/test-plan.pxu (+17/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Needs Fixing
Pierre Equoy Needs Fixing
Review via email: mp+413471@code.launchpad.net

Commit message

Initial check-in for automated tests for Quadrature Encoding Peripheral.

Description of the change

Added single test case to detect QEP devices on PCI bus.
(QEP is only supported on IOTG EHL platforms. The test fails as expected on my IOTG TGL board.)

To post a comment you must log in.
Revision history for this message
Pierre Equoy (pieq) wrote :

Thanks!

Just a quick request below.

review: Needs Fixing
Revision history for this message
Doug Jacobs (djacobs98) wrote :

Added test plans for Full, Manual and Automated so QEP is consistent with other test plans.

Revision history for this message
Pierre Equoy (pieq) wrote :

I spotted a typo in your test (see below).

I'm having trouble testing this on my device, because Checkbox somehow does not recognize the `has_qep` manifest. I'll look into that.

Another issue is that, as expected, these ids (4bc3, 4b81, 4b82, 4b83) don't return anything on my Aaeon EHL board, which means this job is too specific to be useful. We'll need to discuss with Cert on how to go from there. Either have something like what's been done for the GPIO pins (a file per device hosting the proper IDs to be checked), either something else...

review: Needs Fixing
Revision history for this message
Jonathan Cave (jocave) wrote :

If I understand the intention then I don't believe this will work. Checkbox will evaluate the result based only the last statement only, so in the case the line including 4b83. I think some more logic is needed to establish if the detect should pass based on a AND or OR of the searches.

review: Needs Fixing

Unmerged commits

51eae78... by Doug Jacobs

Added test-plan.pxu. Verify tests can run (fails on my hardware as expected.)

22e0a4d... by Doug Jacobs

Added additional test commands to check if QEP is enabled the devices show up in lspci

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/qep/jobs.pxu b/units/qep/jobs.pxu
2index 42a1d0c..f504fda 100644
3--- a/units/qep/jobs.pxu
4+++ b/units/qep/jobs.pxu
5@@ -8,3 +8,7 @@ requires:
6 manifest.has_qep == 'True'
7 command:
8 lspci | grep -i 4bc3 | cut -c 1-7
9+ lscpi | grep -i 4b81 | cut -c 1-7
10+ lscpi | grep -i 4b82 | cut -c 1-7
11+ lscpi | grep -i 4b83 | cut -c 1-7
12+
13diff --git a/units/qep/test-plan.pxu b/units/qep/test-plan.pxu
14new file mode 100644
15index 0000000..a801f4c
16--- /dev/null
17+++ b/units/qep/test-plan.pxu
18@@ -0,0 +1,17 @@
19+id: qep-full
20+_name: Quadrature Encoder Peripheral (QEP) tests
21+unit: test plan
22+include:
23+nested_part:
24+ qep-manual
25+ qep-automated
26+
27+id: qep-manual
28+_name: Quadrature Encoder Peripheral (QEP) test (manual)
29+unit: test plan
30+include:
31+
32+id: qep-automated
33+_name: Quadrature Encoder Peripheral (QEP) test (automated)
34+unit: test plan
35+include: qep/detect

Subscribers

People subscribed via source and target branches