usb-creator

Merge lp:~diwic/usb-creator/trunk into lp:usb-creator

  1. trunk
  2. Merge into trunk
Proposed by David Henningsson
Status: Rejected
Rejected by: Dimitri John Ledkov
Proposed branch: lp:~diwic/usb-creator/trunk
Merge into: lp:usb-creator
Diff against target: 11 lines (+1/-1)
1 file modified
usbcreator/frontends/gtk/frontend.py (+1/-1)
To merge this branch: bzr merge lp:~diwic/usb-creator/trunk
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Disapprove
Review via email: mp+73753@code.launchpad.net

Description of the change

Fixes crash at startup (bug #839310).

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

As noted in the bug report, this has been fixed by Pitti.
Thanks for submitting the merge proposal, but I will reject it, since the typpo/bugfix has already landed in trunk.

review: Disapprove

Unmerged revisions

353. By David Henningsson

(LP: #839310) Fix error "Argument 3 does not allow None as a value"

This error causes usb-creator not to start at all.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'usbcreator/frontends/gtk/frontend.py'
2--- usbcreator/frontends/gtk/frontend.py 2011-08-17 06:22:09 +0000
3+++ usbcreator/frontends/gtk/frontend.py 2011-09-02 08:36:38 +0000
4@@ -761,6 +761,6 @@
5 model = treeview.get_model()
6 new_iter = model.append(new_row)
7 if force_selection or (treeview.get_selection().get_selected()[1] is None):
8- treeview.set_cursor(model.get_path(new_iter), None, None)
9+ treeview.set_cursor(model.get_path(new_iter), None, False)
10
11 # vim: set ai et sts=4 tabstop=4 sw=4:

Subscribers

People subscribed via source and target branches