Code review comment for lp:~diwic/unity-control-center/lp1367693
Revision history for this message
| David Henningsson (diwic) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi Robert and thanks for the review,
> I don't know the code in enough detail to know the implications of the change
> but they make sense to me. You should file a bug against libgnome-volume-
> control as their code appears to contain the same error. They're also more
> likely to give a better review.
The first bug has been upstreamed to:
https:/
The second bug is in gvc-mixer-dialog and their gvc-mixer-dialog looks slightly different, so the fix could also be slightly different. And after all it's mostly a band-aid for a PulseAudio oddity, so they may argue that things should be fixed in PA instead (although such a behaviour change would be more difficult and nothing I would want to SRU into trusty).
> Please update the commit message to be more informative of the problem and
> solution.
Done.
> To propose this into trusty make a merge proposal to lp:unity-control-
> center/14.04
Done: https:/