Apport

Merge lp:~diwic/apport/ubuntu.precise into lp:~ubuntu-core-dev/ubuntu/precise/apport/ubuntu

  1. ubuntu.precise
  2. Merge into ubuntu
Proposed by David Henningsson
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~diwic/apport/ubuntu.precise
Merge into: lp:~ubuntu-core-dev/ubuntu/precise/apport/ubuntu
Diff against target: 13 lines (+1/-2)
1 file modified
apport/hookutils.py (+1/-2)
To merge this branch: bzr merge lp:~diwic/apport/ubuntu.precise
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+96776@code.launchpad.net

Description of the change

Not sure which of all branches this should be merged into, but it'd be nice to have all this information when triaging bugs (pacmd list contains list-sources, list-sinks, list-cards and more).

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! I applied this patch to lp:apport (upstream trunk) instead, from where it'll flow into the Ubuntu branch. So I'm not directly merging this as it is, but don't get confused about the "rejected" state.

review: Approve

Unmerged revisions

1916. By David Henningsson

Get even more information from PulseAudio in the attach_alsa hook

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'apport/hookutils.py'
2--- apport/hookutils.py 2012-03-02 14:08:02 +0000
3+++ apport/hookutils.py 2012-03-09 15:17:21 +0000
4@@ -287,8 +287,7 @@
5 + glob.glob('/dev/seq*') )
6
7 if os.path.exists('/usr/bin/pacmd'):
8- report['PulseSinks'] = command_output(['pacmd', 'list-sinks'])
9- report['PulseSources'] = command_output(['pacmd', 'list-sources'])
10+ report['PulseList'] = command_output(['pacmd', 'list'])
11
12 attach_dmi(report)
13 attach_dmesg(report)

Subscribers

People subscribed via source and target branches