Divmod

Merge lp:~divmod-dev/divmod.org/logdatetimestart-patch-848342 into lp:divmod.org

  1. logdatetimestart-patch-848342
  2. Merge into trunk
Proposed by Jean-Paul Calderone
Status: Merged
Merged at revision: 2684
Proposed branch: lp:~divmod-dev/divmod.org/logdatetimestart-patch-848342
Merge into: lp:divmod.org
Diff against target: 0 lines
To merge this branch: bzr merge lp:~divmod-dev/divmod.org/logdatetimestart-patch-848342
Reviewer Review Type Date Requested Status
Tristan Seligmann Needs Fixing
Review via email: mp+75079@code.launchpad.net

Description of the change

This removes the monkeypatching of http._logDateTimeStart from the web integration unit tests. Twisted 11.0 removed this private function and made the factory responsible the whole thing. Mantissa doesn't need to do anything to have things work nicely now.

To post a comment you must log in.
Revision history for this message
Tristan Seligmann (mithrandi) wrote :

I get three pyflakes warnings in test_web.py:

Mantissa/xmantissa/test/integration/test_web.py:13: 'http' imported but unused
Mantissa/xmantissa/test/integration/test_web.py:654: local variable 'cookies' is assigned to but never used
Mantissa/xmantissa/test/integration/test_web.py:702: local variable 'cookies' is assigned to but never used

Only the first of these is directly related to your changes, but I guess you might as well fix the other two while you're touching that file.

Once those are fixed, this looks good to merge, thanks!

review: Needs Fixing
lp:~divmod-dev/divmod.org/logdatetimestart-patch-848342 updated
2679. By Jean-Paul Calderone

Address review feedback from mithrandi

Clean up pyflakes warnings about unused names

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: