Merge lp:~divmod-dev/divmod.org/829866-explicit-close into lp:divmod.org

Proposed by Tristan Seligmann
Status: Merged
Approved by: Jonathan Jacobs
Approved revision: 2682
Merged at revision: 2679
Proposed branch: lp:~divmod-dev/divmod.org/829866-explicit-close
Merge into: lp:divmod.org
Prerequisite: lp:~divmod-dev/divmod.org/829865-PYTHONPATH-handling
Diff against target: 33 lines (+3/-2)
2 files modified
Axiom/axiom/test/test_batch.py (+1/-0)
Axiom/axiom/test/test_files.py (+2/-2)
To merge this branch: bzr merge lp:~divmod-dev/divmod.org/829866-explicit-close
Reviewer Review Type Date Requested Status
Jonathan Jacobs Approve
Review via email: mp+72275@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Jacobs (jjacobs) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Axiom/axiom/test/test_batch.py'
2--- Axiom/axiom/test/test_batch.py 2009-07-07 20:35:43 +0000
3+++ Axiom/axiom/test/test_batch.py 2011-08-20 01:56:18 +0000
4@@ -562,6 +562,7 @@
5 ss = substore.SubStore.createNew(s, 'substore')
6 service.IService(s).startService()
7 d = iaxiom.IBatchService(ss).call(BatchCallTestItem(store=ss.open()).callIt)
8+ ss.close()
9 def called(ign):
10 self.failUnless(ss.open().findUnique(BatchCallTestItem).called, "Was not called")
11 return service.IService(s).stopService()
12
13=== modified file 'Axiom/axiom/test/test_files.py'
14--- Axiom/axiom/test/test_files.py 2008-05-06 13:33:30 +0000
15+++ Axiom/axiom/test/test_files.py 2011-08-20 01:56:18 +0000
16@@ -73,7 +73,7 @@
17 TEST_STR = "test 123"
18
19 def cb(fpath):
20- fpath.open("w").write(TEST_STR)
21+ fpath.setContent(TEST_STR)
22
23 PathTesterItem(store=s,
24 relpath=fpath)
25@@ -83,7 +83,7 @@
26 s2 = Store(npath)
27 pti = list(s2.query(PathTesterItem))[0]
28
29- self.assertEquals(pti.relpath.open().read(),
30+ self.assertEquals(pti.relpath.getContent(),
31 TEST_STR)
32
33 return rel.close().addCallback(cb)

Subscribers

People subscribed via source and target branches

to all changes: