Merge ~dirksu/plainbox-provider-checkbox:fixed_orientation into plainbox-provider-checkbox:master

[Dirk Su]

Use property PanelOrientationManaged to check autorotation

In Jammy, mutter add new property PanelOrientationManaged to expose panel auto orientation handling [1]. Proposed to use this property for more precise screen orientation detection. [2] for property description in
jammy source tree.

[1] https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1311
[2] https://git.launchpad.net/ubuntu/+source/mutter/tree/data/dbus-interfaces/org.gnome.Mutter.DisplayConfig.xml?h=ubuntu/jammy#n286

[Kai-Chuan Hsieh (kchsieh)]

LGTM.

review: Approve

[Sylvain Pineau (sylvain-pineau)]

Please confirm the test still works with older releases (e.g focal) and using checkbox remote (as calls to dbus-send may not work as expected).

review: Needs Information

Unmerged commits

5e80d97... by Dirk Su on 2022-09-16

Use property PanelOrientationManaged to check autorotation

Mutter modified the panel autoration determine method and expose
in a PanelOrientationManaged readonly property

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1311

diff --git a/bin/fixed_screen_orientation.sh b/bin/fixed_screen_orientation.sh
index 5fbe162..77e7626 100755
--- a/bin/fixed_screen_orientation.sh
+++ b/bin/fixed_screen_orientation.sh
@@ -1,22 +1,34 @@
 #!/bin/sh
-if ! (udevadm info --export-db | grep -q iio_device); then
-   echo "Screen orientation check PASSED:"
-   echo "no iio_device found in this device, therefore rotation should not happen."
-   exit 0
-fi
+orientation_managed=$(dbus-send --session --print-reply --dest=org.gnome.Mutter.DisplayConfig \
+    /org/gnome/Mutter/DisplayConfig org.freedesktop.DBus.Properties.Get \
+    string:org.gnome.Mutter.DisplayConfig string:PanelOrientationManaged 2>&1)
 
-if dbus-send --system --print-reply --dest=net.hadess.SensorProxy \
-  /net/hadess/SensorProxy \
-  org.freedesktop.DBus.Properties.Get string:net.hadess.SensorProxy string:HasAccelerometer |
-  grep -q "boolean true"; then
-  echo "Screen orientation check FAILED:"
-  echo "this device has an accelerometer that needs to be disabled."
-  echo "==="
-  # list IIO devices for reference
-  echo "udevadm info /sys/bus/iio/devices/iio*"
-  udevadm info /sys/bus/iio/devices/iio*
-  exit 1
-fi
+if echo "$orientation_managed" | grep -q "No such property"; then
+  if ! (udevadm info --export-db | grep -q iio_device); then
+     echo "Screen orientation check PASSED:"
+     echo "no iio_device found in this device, therefore rotation should not happen."
+     exit 0
+  fi
 
-echo "Screen orientation check PASSED:"
-echo "Accelerometer is not enabled."
+  if dbus-send --system --print-reply --dest=net.hadess.SensorProxy \
+    /net/hadess/SensorProxy \
+    org.freedesktop.DBus.Properties.Get string:net.hadess.SensorProxy string:HasAccelerometer |
+    grep -q "boolean true"; then
+    echo "Screen orientation check FAILED:"
+    echo "this device has an accelerometer that needs to be disabled."
+    echo "==="
+    # list IIO devices for reference
+    echo "udevadm info /sys/bus/iio/devices/iio*"
+    udevadm info /sys/bus/iio/devices/iio*
+    exit 1
+  fi
+
+  echo "Screen orientation check PASSED:"
+  echo "Accelerometer is not enabled."
+else
+    if echo "$orientation_managed" | grep -q "boolean false"; then
+    echo "Screen orientation check PASSED:"
+  else
+    echo "Screen orientation check FAILED:"
+  fi
+fi