Code review comment for ~dirk.zimoch/epics-base:FilterForInfoFields
Revision history for this message
| Andrew Johnson (anj) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Can we keep any chfPlugin enhancements on a separate branch and as a separate PR please. If you mix them up you would be delaying the merge of the new filter and also complicating the review process, so separate is better. It would be okay to include modifications to streamline the existing filters in the PR that enhances the chfPlugin code.
You could include that suggested shortcut to the filter params here though, it looks much better than having the separate longstr parameter. I would also maybe use the shortcut in the Release Notes example, and even drop the quotes there so users who see it there start to recognize that the quotes aren't needed.