Code review comment for ~dirk.zimoch/epics-base:FilterForInfoFields

Revision history for this message
Dirk Zimoch (dirk.zimoch) wrote :

I am at commit 663e6442e47ea7329217f60b6ca3e5c6d636620d which is based on 3ba778c08bfbf6364bdbefa41f16022b4c0f41d5, before your refactory was merged in.
I have not pushed the re-base on top of f571c5950bfe476ef79d4c143f50e2f9e0d5edc7.

What fails: I get garbage instead of the correct data. Don't know yet where it came from. I suspect it has to do with the new dbfl_has_copy() logic.

I could fix my code by adding a dummy pfl->u.r.dtor in order to claim "ownership" of the data for the logic in dbAccess.c. The desctructor does nothing, as the data does not need to be destroyed, but otherwise dbAccess.c takes a few wrong branches, it seems.

I have not analyzed the exact path of execution before and after. I have checked which your commits (cherry-picked onto my branch) broke my code and then which modified line. I got the first problem with commit 85822f in dbAccess.c line 918. Reverting that line restored my functionality. But later commits broke it again. So I checked what changed there.

I found out that adding a dtor seems to fix everything. I will commit than now and rebase this branch.

« Back to merge proposal