EPICS Base

Code review comment for ~dirk.zimoch/epics-base:iocLogClientFixesTry2

  1. Git
  2. lp:~dirk.zimoch/epics-base
  3. iocLogClientFixesTry2
  4. Merge into 7.0
Revision history for this message
Dirk Zimoch (dirk.zimoch) wrote :

It is totally fine for me to keep os-specific unsent cound inside logClient as a bunch of #if branches.

'send(NULL)' is not race condition, because I do not rely on getting the RST right after sending. It is fine to get it at some point. It simply polls for RST every 5 seconds.

Maybe it is better to use the other approach: https://code.launchpad.net/~dirk.zimoch/epics-base/+git/epics-base/+merge/372043. This one is very os-dependent and uses unspecified behavior.

« Back to merge proposal