Code review comment for ~dirk.zimoch/epics-base:named-events-backward-compatibility

Revision history for this message
Ralph Lange (ralph-lange) wrote :

Uh-oh.

As for my original concern, I misunderstood how this was going to be implemented.
I'm fine with mapping to appropriate strings that would be ignored (no records waiting) by default and could be used in an exception handling fashion if desired.

As for the numeric conversions, I would try to be reasonable and minimally invasive, e.g.
If and only if number is in the interval [1...256[ remove the fractional part.
Convert in the %f-variant of the %g style: don't show insignificant zeroes to the right of the decimal point, and don't include the decimal point on whole numbers.

Removing trailing and leading whitespace is fine.

« Back to merge proposal