Merge ~dipietro-salvatore/ubuntu/+source/nginx:arm64-moutline-atomics into ubuntu/+source/nginx:ubuntu/focal-security
Proposed by
Salvatore
| Status: | Needs review |
|---|---|
| Proposed branch: | ~dipietro-salvatore/ubuntu/+source/nginx:arm64-moutline-atomics |
| Merge into: | ubuntu/+source/nginx:ubuntu/focal-security |
| Diff against target: |
13 lines (+2/-0) 1 file modified
debian/rules (+2/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Łukasz Zemczak (community) | Needs Information | ||
| git-ubuntu import | Pending | ||
|
Review via email:
|
|||
Commit message
Add GCC atomic support (-moutline-atomics) for arm64
Description of the change
Add "-moutline-atomics" cflag for arm64 architecture since it is not active by default on GCC 9. Without this flag, the CPU doesn't use atomics instructions resulting in poor performance and CPU saturation. With this change, NGINX does not produce STREX failing operations anymore (observable with perf tool).
To post a comment you must log in.
Unmerged commits
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you for the proposed change. Could you fill in a bug for this, attach it to this MP (via the "Link a bug report" button) and subscribe ubuntu-sponsors there? As this is a change proposed to focal, this requires a bit discussion. Like, is there a regression potential here? What's the state of this in newer Ubuntu series? Is it focal specific?
A bug is a much better place for such discussions, and also a better anchor for the security team (or the maintainers of nginx packages) to find and participate.