Merge lp:~dinko-metalac/sudoku-app/fix-for-1356344 into lp:sudoku-app

Proposed by Dinko Osmankovic
Status: Merged
Approved by: Dinko Osmankovic
Approved revision: 259
Merged at revision: 262
Proposed branch: lp:~dinko-metalac/sudoku-app/fix-for-1356344
Merge into: lp:sudoku-app
Diff against target: 76 lines (+7/-5)
4 files modified
components/BigBlock.qml (+0/-1)
components/SudokuBlocksGrid.qml (+1/-0)
js/localStorage.js (+4/-1)
sudoku-app.qml (+2/-3)
To merge this branch: bzr merge lp:~dinko-metalac/sudoku-app/fix-for-1356344
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+231334@code.launchpad.net

Commit message

Fix for bug #1356344

Description of the change

Fix for bug #1356344

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components/BigBlock.qml'
2--- components/BigBlock.qml 2014-08-08 22:12:23 +0000
3+++ components/BigBlock.qml 2014-08-19 10:49:38 +0000
4@@ -7,7 +7,6 @@
5 UbuntuShape {
6 width: 3*blockSize + 5*blockDistance
7 height: 3*blockSize + 5*blockDistance
8- color: UbuntuColors.warmGrey
9 id: block
10 Rectangle {
11 height: parent.height - units.dp(6)
12
13=== modified file 'components/SudokuBlocksGrid.qml'
14--- components/SudokuBlocksGrid.qml 2014-08-08 22:12:23 +0000
15+++ components/SudokuBlocksGrid.qml 2014-08-19 10:49:38 +0000
16@@ -529,6 +529,7 @@
17 id: blocks
18 BigBlock {
19 id: block
20+ color: index % 2 == 0 ? UbuntuColors.warmGrey : Qt.lighter(UbuntuColors.warmGrey, 1.15)
21 }
22 }
23 }
24
25=== modified file 'js/localStorage.js'
26--- js/localStorage.js 2014-04-08 21:18:51 +0000
27+++ js/localStorage.js 2014-08-19 10:49:38 +0000
28@@ -8,6 +8,9 @@
29
30 function initialize() {
31 var db = getDatabase();
32+ var fname = i18n.tr("Sudoku")
33+ var lname = i18n.tr("User")
34+
35 db.transaction(
36 function(tx) {
37 // Create the settings table if it doesn't already exist
38@@ -20,7 +23,7 @@
39 tx.executeSql('CREATE TABLE IF NOT EXISTS profiles(id INTEGER PRIMARY KEY AUTOINCREMENT, first_name TEXT, last_name TEXT, UNIQUE(first_name, last_name) ON CONFLICT ROLLBACK)');
40 //print("profile table created.")
41
42- tx.executeSql('INSERT OR IGNORE INTO profiles VALUES (null,?,?);', ["Sudoku","User"]);
43+ tx.executeSql('INSERT OR IGNORE INTO profiles VALUES (null,?,?);', [fname, lname]);
44 tx.executeSql('CREATE TABLE IF NOT EXISTS scores(id INTEGER PRIMARY KEY AUTOINCREMENT, profile_id INTEGER, score INTEGER NOT NULL, game_date DATE, FOREIGN KEY(profile_id) REFERENCES profiles(id))');
45 //print("scores table created.")
46
47
48=== modified file 'sudoku-app.qml'
49--- sudoku-app.qml 2014-08-11 10:39:57 +0000
50+++ sudoku-app.qml 2014-08-19 10:49:38 +0000
51@@ -193,7 +193,6 @@
52 }
53
54 function insertNewGameScore(userId, score) {
55- print(userId,score)
56 Settings.insertNewScore(userId, score)
57 }
58
59@@ -207,7 +206,7 @@
60 highscoresHeaderText = i18n.tr("<b>Best scores for all players</b>");
61 for(var i = 0; i < allScores.length; i++) {
62 var rowItem = allScores[i];
63- print("ROW ",rowItem)
64+ //print("ROW ",rowItem)
65 var firstName = Settings.getUserFirstName(rowItem[0]);
66 var lastName = Settings.getUserLastName(rowItem[0]);
67 //res.push([dbItem.first_name, dbItem.last_name, dbItem.score])
68@@ -620,7 +619,7 @@
69 settingsTab.difficultyIndex = parseInt(Settings.getSetting("Difficulty"));
70 if (settingsTab.difficultyIndex < 0)
71 settingsTab.difficultyIndex = 0
72- print(settingsTab.difficultyIndex)
73+ //print(settingsTab.difficultyIndex)
74 //print(Settings.getSetting("DisableHints"));
75 settingsTab.disableHintsChecked = Settings.getSetting("DisableHints") == "true" ? true : false;
76 settingsTab.disableVibrationsChecked = Settings.getSetting("DisableVibrations") == "true" ? true : false;

Subscribers

People subscribed via source and target branches