Merge lp:~dinko-metalac/sudoku-app/bug-fix-1295928 into lp:sudoku-app

Proposed by Dinko Osmankovic
Status: Merged
Approved by: Dinko Osmankovic
Approved revision: 180
Merged at revision: 180
Proposed branch: lp:~dinko-metalac/sudoku-app/bug-fix-1295928
Merge into: lp:sudoku-app
Diff against target: 38 lines (+18/-1)
1 file modified
sudoku-app.qml (+18/-1)
To merge this branch: bzr merge lp:~dinko-metalac/sudoku-app/bug-fix-1295928
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+212369@code.launchpad.net

Commit message

Fix for bug #1295928

Description of the change

Fix for bug #1295928

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sudoku-app.qml'
2--- sudoku-app.qml 2014-03-20 08:25:38 +0000
3+++ sudoku-app.qml 2014-03-24 09:39:16 +0000
4@@ -919,6 +919,22 @@
5 ListModel {
6 id: highscoresModel
7
8+ onDataChanged: {
9+ var allScores = Settings.getAllScores()
10+ highscoresModel.clear();
11+ highscoresHeaderText = i18n.tr("<b>Best scores for all players</b>");
12+ for(var i = 0; i < allScores.length; i++) {
13+ var rowItem = allScores[i];
14+ //print("ROW ",rowItem)
15+ var firstName = Settings.getUserFirstName(rowItem[0]);
16+ var lastName = Settings.getUserLastName(rowItem[0]);
17+ //res.push([dbItem.first_name, dbItem.last_name, dbItem.score])
18+ highscoresModel.append({'firstname': firstName,
19+ 'lastname': lastName,
20+ 'score': rowItem[1] });
21+ }
22+ }
23+
24 /*ListElement {
25 firstname: "Bill"
26 lastname: "Smith"
27@@ -934,9 +950,10 @@
28 anchors.fill: parent
29 clip: true
30 ListView {
31+ id: highScoresListView
32 model: highscoresModel
33 width: parent.width
34- height:parent.height
35+ height:parent.height
36
37 header: ListItem.Header {
38 id: highscoresHeader

Subscribers

People subscribed via source and target branches