Merge lp:~dinko-metalac/sudoku-app/bug-fix-1231700 into lp:sudoku-app

Proposed by Dinko Osmankovic
Status: Merged
Approved by: Dinko Osmankovic
Approved revision: 116
Merged at revision: 120
Proposed branch: lp:~dinko-metalac/sudoku-app/bug-fix-1231700
Merge into: lp:sudoku-app
Diff against target: 70 lines (+11/-7)
1 file modified
sudoku-app.qml (+11/-7)
To merge this branch: bzr merge lp:~dinko-metalac/sudoku-app/bug-fix-1231700
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+188236@code.launchpad.net

Commit message

--fixes lp:1231700

Description of the change

Bug fix for #1231700

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:115
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dinko-metalac/sudoku-app/bug-fix-1231700/+merge/188236/+edit-commit-message

http://91.189.93.70:8080/job/sudoku-app-ci/23/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/555
    SUCCESS: http://91.189.93.70:8080/job/sudoku-app-precise-amd64-ci/23
    SUCCESS: http://91.189.93.70:8080/job/sudoku-app-quantal-amd64-ci/23
    SUCCESS: http://91.189.93.70:8080/job/sudoku-app-raring-amd64-ci/23
    SUCCESS: http://91.189.93.70:8080/job/sudoku-app-saucy-amd64-ci/23

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/sudoku-app-ci/23/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sudoku-app.qml'
2--- sudoku-app.qml 2013-09-11 09:21:47 +0000
3+++ sudoku-app.qml 2013-09-29 21:08:52 +0000
4@@ -259,6 +259,9 @@
5 randomnumber += 17;
6 sudokuBlocksGrid.createNewGame(81 - randomnumber);
7 break;
8+ case 4:
9+ PopupUtils.open(newGameComponent)
10+ break;
11 }
12 }
13
14@@ -345,7 +348,7 @@
15 sudokuBlocksGrid.createNewGame(81 - randomnumber);
16 PopupUtils.close(newGameDialogue)
17 sudokuBlocksGrid.gameDifficulty = 0
18- toolbar.opened = false;
19+ //toolbar.opened = false;
20 }
21 }
22 NewGameSelectionButton {
23@@ -362,7 +365,7 @@
24 sudokuBlocksGrid.createNewGame(81 - randomnumber);
25 PopupUtils.close(newGameDialogue)
26 sudokuBlocksGrid.gameDifficulty = 1
27- toolbar.opened = false;
28+ //toolbar.opened = false;
29 }
30 }
31 NewGameSelectionButton {
32@@ -379,7 +382,7 @@
33 sudokuBlocksGrid.createNewGame(81 - randomnumber);
34 PopupUtils.close(newGameDialogue)
35 sudokuBlocksGrid.gameDifficulty = 2
36- toolbar.opened = false;
37+ //toolbar.opened = false;
38 }
39 }
40 NewGameSelectionButton {
41@@ -396,7 +399,7 @@
42 sudokuBlocksGrid.createNewGame(81 - randomnumber);
43 PopupUtils.close(newGameDialogue)
44 sudokuBlocksGrid.gameDifficulty = 3
45- toolbar.opened = false;
46+ //toolbar.opened = false;
47 }
48 }
49
50@@ -561,6 +564,7 @@
51 page: Page {
52
53 tools: ToolbarItems {
54+ opened: true
55 ToolbarButton {
56 objectName: "newgamebutton"
57 action: Action {
58@@ -570,9 +574,9 @@
59 if(gameFinishedRectangle.visible) gameFinishedRectangle.visible = false;
60 //print("new block distance:", blockDistance);
61 //createNewGame()
62- if (settingsTab.difficultyIndex == 4)
63- PopupUtils.open(newGameComponent)
64- else
65+ //if (settingsTab.difficultyIndex == 4)
66+ // PopupUtils.open(newGameComponent)
67+ //else
68 createNewGame()
69 }
70 }

Subscribers

People subscribed via source and target branches