Merge lp:~dinko-metalac/sudoku-app/bug-fix-1227340 into lp:sudoku-app

Proposed by Dinko Osmankovic
Status: Merged
Approved by: Dinko Osmankovic
Approved revision: 114
Merged at revision: 117
Proposed branch: lp:~dinko-metalac/sudoku-app/bug-fix-1227340
Merge into: lp:sudoku-app
Diff against target: 22 lines (+12/-0)
1 file modified
tests/autopilot/sudoku_app/tests/__init__.py (+12/-0)
To merge this branch: bzr merge lp:~dinko-metalac/sudoku-app/bug-fix-1227340
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+186480@code.launchpad.net

Commit message

Bug fix for #1227340

Description of the change

Fix for bug #1227340

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Nice work Dinko! Just a small tip: if you use the --fixes lp:1227340 argument when you're doing the bzr commit, Launchpad will take care of marking the bug as Fix Committed automatically for you.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Dinko Osmankovic (dinko-metalac) wrote :

Hehehe, I have no idea if its fixed now. It worked before on my side :D

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/sudoku_app/tests/__init__.py'
2--- tests/autopilot/sudoku_app/tests/__init__.py 2013-08-30 16:16:40 +0000
3+++ tests/autopilot/sudoku_app/tests/__init__.py 2013-09-19 07:59:49 +0000
4@@ -71,6 +71,18 @@
5 pass
6 return None
7
8+ def launch_and_quit_app(self):
9+ self.launch_app()
10+ self.main_window.get_qml_view().visible.wait_for(True)
11+
12+ # When calling launch_app an instance of the spawned process
13+ # control object will be stored in self.app.process, and a cleanup
14+ # handler will be registered that essentially kills the process.
15+ # Therefore, by triggering the cleanup handler here we're killing the
16+ # process and removing the handler, which allows a clean launch of
17+ # the process during regular test setup.
18+ self.doCleanups()
19+
20 def clean_db(self):
21 path = self.find_db()
22 if path is None:

Subscribers

People subscribed via source and target branches